Conversation
jeffbl
approved these changes
Sep 12, 2025
Member
jeffbl
left a comment
jeffbl
left a comment
There was a problem hiding this comment.
Lots of changes! I have no way to review this in detail, so best I can do is say let's push it as a test extension, and I'll spend some time testing. Might be a while before pushing to production, since I'd like Samyuktha/Venissa to test with Monarch/TAT as well.
Before merging, please add a brief overview (maybe just a few sentences) on how the code in src fits together. Could be a new README.md in the src folder if that is best. (Alternative would be to add some comments at the top of each file, if you prefer that approach.) Think of a developer joining who will need to add a new message type, etc. What would you tell them when they asked for an overview?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.