Skip to content

Remove unused Client::setResponseFactory() #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loevgaard merged 1 commit into from
Jun 15, 2026
Merged

Remove unused Client::setResponseFactory() #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/Client/Client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
use Http\Discovery\Psr18ClientDiscovery;
use Psr\Http\Client\ClientInterface as HttpClientInterface;
use Psr\Http\Message\RequestFactoryInterface;
use Psr\Http\Message\ResponseFactoryInterface;
use Psr\Http\Message\StreamFactoryInterface;
use Psr\Log\LoggerAwareInterface;
use Psr\Log\LoggerInterface;
Expand Down Expand Up @@ -99,13 +98,6 @@ public function setRequestFactory(RequestFactoryInterface $requestFactory): void
$this->requestFactory = $requestFactory;
}

/**
* @deprecated the client does not create responses, so the response factory is not used; this method is kept for backwards compatibility only
*/
public function setResponseFactory(ResponseFactoryInterface $responseFactory): void
{
}

private function getStreamFactory(): StreamFactoryInterface
{
if (null === $this->streamFactory) {
Expand Down
Loading