Rewrite OMCPlugin (features and registry)#1241
Open
iambibi wants to merge 2 commits intoServerOpenMC:masterfrom
Open
Rewrite OMCPlugin (features and registry)#1241iambibi wants to merge 2 commits intoServerOpenMC:masterfrom
iambibi wants to merge 2 commits intoServerOpenMC:masterfrom
Conversation
gab4000
reviewed
Mar 29, 2026
| OMCPlugin.getInstance().logSuccessMessage("Feature " + this.getClass().getSimpleName() + " initialisée correctement."); | ||
| } catch (Exception e) { | ||
| initialize = false; | ||
| OMCPlugin.getInstance().logSuccessMessage("Feature " + this.getClass().getSimpleName() + " pas initialisée correctement."); |
Contributor
There was a problem hiding this comment.
juste "mal initialisée" ou "non initialisée"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Petit résumé de la PR:
J'ai ajouté un handler pour les Features, j'ai plus sécurisé avec un boolean qui dit si la feature est correctement initialisé afin de pouvoir se save (car si save clear la table et que init ne s'est pas executer = table vide).
Je ne sais pas encore si je vais rewrite les registry.
Étape nécessaire afin que la PR soit fini (si PR en draft)
Decrivez vos changements