feat: add Docker containerization support#1648
Open
VargaJoe wants to merge 7 commits intofeature/sn-auth-package-extraimprovementsfrom
Open
feat: add Docker containerization support#1648VargaJoe wants to merge 7 commits intofeature/sn-auth-package-extraimprovementsfrom
VargaJoe wants to merge 7 commits intofeature/sn-auth-package-extraimprovementsfrom
Conversation
- Add Dockerfile for SenseNet client application - Add docker-compose.dev.yml for development with hot reload - Add docker-compose.prod.yml for production deployment - Add .dockerignore for optimized builds - Add .env.example for environment configuration Usage: - Development: docker-compose -f docker-compose.dev.yml up -d - Production: docker-compose -f docker-compose.prod.yml up -d
- Add GitHub Actions workflow for Docker image builds - Builds and pushes to DockerHub with smart tagging - Triggers on pushes to docker-containerization branch - Triggers on PRs to develop, main, and sn-auth-package-extraimprovements - Safely skips build if no Dockerfile exists - Uses branch-based and SHA-based tags for versioning
- Fix invalid tag format causing build failure - Use proper suffix/prefix for SHA tags - Ensure Docker tag compliance
- Skip draft PRs to avoid duplicate builds - Only trigger PR builds when PR is ready for review - Maintain push-based builds for active development
- Remove standalone SHA tags to prevent DockerHub clutter - Keep clean branch names and branch+SHA tags for useful scenarios - Maintain manageable tag strategy for long-term development
- Removed multi-stage Dockerfile complexity - Updated documentation to match single Dockerfile approach - Both dev and prod modes use 'yarn snapp start' - Development uses volume mounts for hot reload - Production uses built-in code without volumes - Simplified and cleaner Docker setup
VargaJoe
requested review from
HegyiOliver,
NoelKova,
hassanad94 and
marosvolgyiz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Docker containerization to enable easy deployment and development setup.
What's Added
yarn snapp startUsage