perf(qwen3.5-fp4-b200-sglang-mtp): add TEP2 arm - #2550
perf(qwen3.5-fp4-b200-sglang-mtp): add TEP2 arm#2550hshrivastava-droid wants to merge 4 commits into
Conversation
Add a TP2/EP2 arm to the Qwen3.5-397B-A17B NVFP4 B200 SGLang MTP 8k/1k sweep at concurrency 16/32/64, alongside the existing TP2/EP1 rows.
|
Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase For PR verification, add the PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs 感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 如需进行 PR 验证,请为此 PR 添加 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档 |
There was a problem hiding this comment.
LGTM — straightforward benchmark config addition.
Extended reasoning...
Overview
This PR adds a single new search-space arm (tp:2, ep:2, conc-list:[16,32,64], spec-decoding:mtp) to the existing qwen3.5-fp4-b200-sglang-mtp sweep in configs/nvidia-master.yaml, and appends a corresponding perf-changelog.yaml entry documenting the measured gains (+5-9% tok/s/GPU and tok/s/user across concurrencies 16/32/64) and correctness checks (GSM8K strict-match/flexible-extract above threshold, coherence pass, MTP acceptance baseline-like).
Security risks
None. This is a pure benchmark configuration change — no code paths, auth, or data handling are touched.
Level of scrutiny
Low. This follows the exact same mechanical pattern used throughout this file for adding sweep arms (confirmed conc-list syntax matches other entries in the config), and the changelog entry follows the established schema with the required fields (config-keys, scenario-type, description, pr-link) matching the format of adjacent entries.
Other factors
No outstanding review comments in the timeline beyond the standard automated recipe-reminder bot message. The perf-changelog description includes specific before/after benchmark numbers and correctness validation results, consistent with prior similar TEP-arm-addition PRs in the repo history.
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=31432304739 |
|
/reuse-sweep-run 31432304739 |
|
As a PR reviewer and CODEOWNER, I have reviewed this and have:
Additional detail section:Scope of the change. This PR adds a single search-space row to the existing Validation and eval evidence. Run 31432304739 ran on the exact PR head Speculative decoding and chat template. The new arm is a real configuration, not a relabel. The script consumes expert parallelism directly — Model and scenario scope. MODELS.md lists Qwen3.5-397B-A17B as active for Single-turn 8k1k limited to fp8/fp4, and records the deprecations as Single-turn 1k1k, Single-turn 1k8k, and all bf16 recipes. This submission is 8k1k NVFP4 and adds no 1k1k lane. MODELS.md also records the engine expectation for this model as the native/upstream SGLang engine with native MTP, which is exactly what this arm exercises on the upstream Single-node recipe publication — left unchecked, needs a scope call. This is a single-node SGLang submission, so the item is at least arguably in scope, and no upstream recipe or cookbook link has been provided on this PR. Against that: the PR introduces no recipe file and no new serving script — it extends an already-published single-node config's search space with a parallelism variant, and the underlying No engine or serving-stack patching. The diff is two YAML files. No Signed: |
❌❌❌ REJECTED ❌❌❌@Ankur-singh Blocking issue: this is a single-node SGLang submission, but no merged upstream recipe PR or published cookbook page is linked in the sign-off (the recipe checklist item is unchecked). The new ✅ Check 0 (CODEOWNER): PASS — |
|
/reuse-sweep-run |
2 similar comments
|
/reuse-sweep-run |
|
/reuse-sweep-run |
# Conflicts: # perf-changelog.yaml
|
/reuse-sweep-run |
# Conflicts: # perf-changelog.yaml
@Klaud-Cold add PR description