Skip to content

Remove duplicate front matter keys from Japanese legacy docs#2665

Open
noritaka1166 wants to merge 1 commit into
SeleniumHQ:trunkfrom
noritaka1166:fix-ja-legacy-frontmatter
Open

Remove duplicate front matter keys from Japanese legacy docs#2665
noritaka1166 wants to merge 1 commit into
SeleniumHQ:trunkfrom
noritaka1166:fix-ja-legacy-frontmatter

Conversation

@noritaka1166

Copy link
Copy Markdown
Contributor

Description

Removes duplicate front matter keys from two Japanese legacy documentation pages:

  • aliases in the Selenium 2 upgrading page
  • description in the Selenium 3 index page

Motivation and Context

These duplicated front matter keys can make the page metadata ambiguous and may cause Hugo to warn or behave unexpectedly when rendering the documentation. This
keeps the Japanese legacy docs front matter valid and consistent.

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@netlify

netlify Bot commented Jun 20, 2026

Copy link
Copy Markdown

👷 Deploy request for selenium-dev pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit f8d4909

@qodo-code-review

Copy link
Copy Markdown
Contributor

PR Summary by Qodo

Remove duplicate front matter keys from Japanese legacy docs
🐞 Bug fix 📝 Documentation 🕐 Less than 5 minutes

Grey Divider

Description

• Remove duplicate aliases front matter key from Selenium 2 upgrading (JA) legacy page
• Remove duplicate description front matter key from Selenium 3 index (JA) legacy page
• Prevent ambiguous metadata and potential Hugo rendering warnings in Japanese legacy docs
Diagram

graph TD
  A["JA legacy docs"] --> B["Front matter"] --> C["Hugo build/render"]
  D["upgrading.ja.md"] --> B
  E["_index.ja.md"] --> B
  C --> F["Page metadata"]

  subgraph Legend
    direction LR
    _doc["Markdown doc"] ~~~ _cfg["Front matter"] ~~~ _build["Static site build"]
  end
Loading
High-Level Assessment

The chosen approach (remove the duplicated front matter entries at the source) is the most direct and lowest-risk fix. Alternatives like adding build-time linting could help prevent recurrence, but they are additive process changes rather than better solutions for correcting the existing broken metadata.

Files changed (2) +0 / -3

Bug fix (2) +0 / -3
upgrading.ja.mdRemove duplicated 'aliases' front matter entry +0/-2

Remove duplicated 'aliases' front matter entry

• Deletes the second 'aliases: []' front matter key, leaving only the populated aliases list. This avoids ambiguous alias metadata for the page during Hugo rendering.

website_and_docs/content/documentation/legacy/selenium_2/upgrading.ja.md

_index.ja.mdRemove duplicated 'description' front matter entry +0/-1

Remove duplicated 'description' front matter entry

• Removes the extra 'description: >' key so the page has a single description block. This keeps front matter valid and prevents Hugo from needing to resolve conflicting keys.

website_and_docs/content/documentation/legacy/selenium_3/_index.ja.md

@qodo-code-review

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant