[docs] decision: navigation is awaited with expect_navigation / wait_for_url / wait_for_load_state#17676
Open
AutomatedTester wants to merge 1 commit into
Open
[docs] decision: navigation is awaited with expect_navigation / wait_for_url / wait_for_load_state#17676AutomatedTester wants to merge 1 commit into
AutomatedTester wants to merge 1 commit into
Conversation
…for_url / wait_for_load_state
6d5fb76 to
5afcf9d
Compare
Open
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💥 What does this PR do?
Proposes a design decision record: navigation is awaited with
expect_navigation/wait_for_url/wait_for_load_state.A click that triggers navigation is a top source of flaky tests: act-then-wait races because the navigation can complete between the two steps. BiDi emits the full navigation lifecycle (
navigationStarted/navigationCommitted/domContentLoaded/load/navigationFailed/…), and with theexpect_*primitive (record 0001, #17671) these become race-free waits. This record proposes the established Playwright-shaped trio:expect_navigation()(arm-before-action),wait_for_url(), andwait_for_load_state()with a sharedcommit/domcontentloaded/loadvocabulary, consistent across bindings.🔧 Implementation Notes
docs/decisions/process from [docs] add design decision record process and template #17665 — depends on [docs] add design decision record process and template #17665 landing (adds onlydocs/decisions/0006-*.md).expect_*/Subscriptionprimitive proposed in [docs] decision: BiDi events are awaited with expect_* context managers #17671 (record 0001), which should land first.🤖 AI assistance
💡 Additional Considerations
One of a set of BiDi ergonomics decision records proposed together. Cross-binding convergence is tracked in the binding-status table.
🔄 Types of changes