[docs] decision: network responses expose their original body and request timing#17674
Open
AutomatedTester wants to merge 1 commit into
Open
[docs] decision: network responses expose their original body and request timing#17674AutomatedTester wants to merge 1 commit into
AutomatedTester wants to merge 1 commit into
Conversation
883901e to
9114a9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💥 What does this PR do?
Proposes a design decision record: network responses expose their original body and request timing.
The high-level network handlers can mutate/stub traffic but can't read the original response body or expose request timing — the two most common monitoring needs. Both are now supported by BiDi:
network.addDataCollector+network.getDatacapture response (and increasingly request) bodies, andFetchTimingInfo(13 fields) already rides on every request. This record proposesbody()/text()/json()and fetch-then-patch on theResponsewrapper (via managed data collectors) plustimingon theRequestwrapper. Because data collectors are newer and unevenly implemented across browsers, body-read raises a typed "unsupported" error with a capability gate rather than failing silently; timing is always available.🔧 Implementation Notes
docs/decisions/process from [docs] add design decision record process and template #17665 — depends on [docs] add design decision record process and template #17665 landing (adds onlydocs/decisions/0004-*.md).response, addedrequest; Chromium supported, consumed by Puppeteer; known FF redirect-timing edge cases). The binding manages collector lifecycle so users don't juggle collector ids.🤖 AI assistance
💡 Additional Considerations
One of a set of BiDi ergonomics decision records proposed together. Cross-binding convergence is tracked in the binding-status table.
🔄 Types of changes