[docs] decision: storage exposes a typed cookie API and storage_state save/restore#17673
Open
AutomatedTester wants to merge 1 commit into
Open
[docs] decision: storage exposes a typed cookie API and storage_state save/restore#17673AutomatedTester wants to merge 1 commit into
AutomatedTester wants to merge 1 commit into
Conversation
be86795 to
5a87b78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💥 What does this PR do?
Proposes a design decision record: storage exposes a typed cookie API and
storage_statesave/restore.BiDi cookies use an awkward wire shape (
valueis aBytesValuedescriptor, partitioning via a descriptor), so the common "set a session cookie" case carries needless ceremony. And the most-requested workflow — log in once, capture state, restore it to skip login in later sessions (Playwright'sstorage_state) — has no Selenium equivalent. This record proposes a typedCookievalue forset_cookie/get_cookiesplus asave_state/load_statepair, while being explicit that cookies come from the BiDi protocol whereaslocalStorageis captured viascript.evaluateand IndexedDB is out of scope.🔧 Implementation Notes
docs/decisions/process from [docs] add design decision record process and template #17665 — depends on [docs] add design decision record process and template #17665 landing (adds onlydocs/decisions/0003-*.md).storage_statecaptureslocalStorageby evaluating script per origin — the record documents this split deliberately rather than implying uniform protocol support.🤖 AI assistance
💡 Additional Considerations
One of a set of BiDi ergonomics decision records proposed together. The cookie convenience and
storage_stateare kept in one record as a single cohesive storage-ergonomics decision; reviewers who prefer them split can request that. Cross-binding convergence is tracked in the binding-status table.🔄 Types of changes