[py] Replace devtools genrule with proper generate_devtools rule.#11392
Merged
diemol merged 1 commit intoSeleniumHQ:trunkfrom Jan 25, 2023
Merged
[py] Replace devtools genrule with proper generate_devtools rule.#11392diemol merged 1 commit intoSeleniumHQ:trunkfrom
diemol merged 1 commit intoSeleniumHQ:trunkfrom
Conversation
jameshilliard
force-pushed
the
py-generate-devtools
branch
3 times, most recently
from
1898d17 to
06becaa
Compare
aiuto
reviewed
Jan 11, 2023
aiuto
reviewed
Jan 11, 2023
jameshilliard
force-pushed
the
py-generate-devtools
branch
from
06becaa to
42f4f2d
Compare
jameshilliard
requested review from
aiuto
and removed request for
AutomatedTester
Member
|
@jameshilliard would you like to continue with this PR? Some comments were left. |
jameshilliard
force-pushed
the
py-generate-devtools
branch
from
42f4f2d to
27ba73d
Compare
Contributor
Author
Applied suggestions from comments and rebased. |
Member
|
Seems the build is now failing. Could you please check? |
The existing genrule does not handle directories properly.
jameshilliard
force-pushed
the
py-generate-devtools
branch
from
27ba73d to
b207d3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing genrule does not handle directories properly.
See details.