Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a default AWS SDK timeout configuration to avoid indefinitely stuck AWS requests in quickwit-aws.
Changes:
- Introduce an
aws_config::timeout::TimeoutConfigwith connect/read/operation timeouts. - Apply the timeout config when building the shared
SdkConfiginget_aws_config().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Darkheir
force-pushed
the
feat/aws_timeout
branch
2 times, most recently
from
837fcd7 to
6243420
Compare
Signed-off-by: Darkheir <raphael.cohen@sekoia.io>
Darkheir
force-pushed
the
feat/aws_timeout
branch
from
6243420 to
1f93f0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Set a default timeout config for AWS requests. It should prevent having stuck queries.