[CLONE/FIXES][FEATURE]: Generics, lifetimes, where clauses and internal field variant formatting#6
Closed
[CLONE/FIXES][FEATURE]: Generics, lifetimes, where clauses and internal field variant formatting#6
Conversation
- Bump version number before publish - `gen` is a reserved keyword: https://doc.rust-lang.org/edition-guide/rust-2024/gen-keyword.html - Rename all functions named `gen` to `generate` - Allow for local testing via workspaces, however when publishing the local dep needs to be replaced with the published version - This allowed for the actual proc_macro code changes to propegate into the local build.
…the published version
SeedyROM
changed the title
SeedyROM
commented
Jul 15, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Closed
Owner
Author
|
I finally have some free time to focus on this again. There was an issue created with a suggestion I think I'd like to add. |
- Rename `variant_display` to `display` - Support named argument `format=` and first argument for format.
SeedyROM
added
enhancement
jngls
reviewed
Aug 1, 2025
|
|
||
| [dependencies] | ||
| enum-display-macro = { path = "./enum-display-macro" } | ||
| enum-display-macro = { version = "0.1.5", path = "./enum-display-macro" } |
Contributor
There was a problem hiding this comment.
Had no idea you can use both version and path at the same time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Branched from #5, see that PR for full details.
Additions (from #7)
variant_displaytodisplay.Fixes
genas it's a reserved keywordcargo clippyandcargo fmt