ci: add standard fleet CI (fmt/clippy/test/MSRV/coverage) - #2
Merged
Conversation
Adds .github/workflows/ci.yml with fmt, clippy (-D warnings), a ubuntu/macos/windows test matrix, an MSRV build (1.81), an advisory coverage job, and cargo-deny (deny.toml present, no prior deny job). rust-cache after each toolchain step in compiling jobs; all actions SHA-pinned (version ref for the MSRV toolchain). vet.yml untouched. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Add real tests covering the two remaining uncovered production lines: - reader::utf16_z out-of-range offset (defensive empty-string contract); the line was reachable via direct call, so drop the cov:unreachable marker and test it instead. - parse_beef0004 with a long-name offset that decodes empty. The remaining gap was an LLVM drop-cleanup landing pad on the conditional String drop; consume `long` unconditionally via then_some (behavior-identical, idiomatic) so the spurious region disappears at the root. Flip the coverage CI job from advisory (continue-on-error) to the fleet hard gate: fail on any uncovered production line (DA:n,0), honoring cov:unreachable. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the standard fleet `ci.yml` — this repo previously had only cargo-vet + docs + release-plz, so its code was never built/tested/linted in CI.
Jobs
All actions SHA-pinned (version ref for the MSRV toolchain); `Swatinem/rust-cache` after each toolchain step in compiling jobs.
Local verification (macOS, aarch64)
🤖 Generated with Claude Code