feat(big-bin): big binary for all services#597
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #597 +/- ##
==========================================
- Coverage 61.99% 61.79% -0.20%
==========================================
Files 381 381
Lines 30871 30970 +99
==========================================
Hits 19138 19138
- Misses 11733 11832 +99 see 4 files with indirect coverage changes
🚀 New features to boost your workflow:
|
| let email_service_channel = tonic::transport::Channel::from_shared(email_service_address) | ||
| .context("create channel to email service")? | ||
| .connect_lazy(); | ||
| let email_service_client = | ||
| pb::scufflecloud::email::v1::email_service_client::EmailServiceClient::new(email_service_channel); |
There was a problem hiding this comment.
I think, i dont like this. In theory we should be able to somehow use the actual service itself.
There was a problem hiding this comment.
You mean without networking?
🚀 Preview Deployments
|
|
Why combine the email and core services into a single binary? What are the advantages of this approach over using them as separate microservices? |
Primarily for development right now, it's much simpler to just run one binary instead of having to start a few binaries in a specific order. Especially when we add even more services later. |
That makes sense. It's simpler to run and build one binary, especially as we add more services. |
lennartkloock
force-pushed
the
lennart/big-bin
branch
from
3b50158 to
964ccd7
Compare
|
Stale because of the comment above #597 (comment) |
3 participants
This PR adds a new binary that executes both the email and the core service. A lot of code here is copied from the other binaries.