zulufx25*: add version 25.32.21 (jdk and jre)#584
Open
minichiello wants to merge 4 commits intoScoopInstaller:masterfrom
Open
zulufx25*: add version 25.32.21 (jdk and jre)#584minichiello wants to merge 4 commits intoScoopInstaller:masterfrom
minichiello wants to merge 4 commits intoScoopInstaller:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
WalkthroughTwo new Windows x64 package manifests added for Zulu OpenJFX: Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with zulufx25-jdk
zulufx25-jre
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@bucket/zulufx25-jdk.json`:
- Around line 20-25: The checkver block's URL in the checkver object leaves the
java_version parameter empty which breaks Azul API queries; update the "url"
value inside the checkver object (the URL string used by checkver) to set
java_version=25 (e.g., replace "java_version=" with "java_version=25") so the
check for the zulufx25-jdk release returns correct results; target the
"checkver" -> "url" string in the zulufx25-jdk.json file.
- Around line 26-37: The autoupdate hash URL in the "autoupdate" ->
"architecture" -> "64bit" block contains an empty java_version parameter
("java_version=") which prevents SHA-256 retrieval; update that URL's query to
use "java_version=25" so it matches the package version used by this manifest
(change the java_version value in the hash URL string in zulufx25-jdk.json to
25, mirroring the pattern used in zulufx22-jdk.json).
In `@bucket/zulufx25-jre.json`:
- Around line 26-37: Update the autoupdate hash URL to include the correct Java
version: change the query parameter in the autoupdate -> architecture -> "64bit"
-> hash.url from "java_version=" to "java_version=25" so the Azul API returns
the SHA-256 hash for this JRE package.
- Around line 20-25: The checkver block's URL has an empty java_version
parameter which breaks Azul API queries; update the "checkver" -> "url" value to
include java_version=25 (e.g., replace "java_version=" with "java_version=25")
so the check uses Java 25, keeping the rest of the URL, the "jsonpath" and the
existing "regex"
("(?<name>zulu(?<version>[\\d.]+)-ca-fx-jre(?<java>[\\d.]+)-win)_x64.zip") and
"replace" behavior intact.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: bed0bd50-56d5-46fb-bc36-4fd155fea5fa
📒 Files selected for processing (2)
bucket/zulufx25-jdk.jsonbucket/zulufx25-jre.json
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
minichiello
commented
Apr 10, 2026
Author
minichiello
left a comment
minichiello
left a comment
There was a problem hiding this comment.
Fix the version to 25 on java_version
Author
|
/verify |
Contributor
|
All changes look good. Wait for review from human collaborators. zulufx25-jdk
zulufx25-jre
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add:
zulufx25-jdk
zulufx25-jre
Summary by CodeRabbit
New Features