refactor: positive priority variables are no longer "sticky" in eliminate_perfect_aliases!#4635
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @variables x(t) y(t) | ||
| @named sys = System([D(x) ~ -x, x ~ y], t; state_priorities = [x => 5, y => 5]) | ||
| state = TearingState(sys) | ||
| @test_logs (:warn, r"state_priority") match_mode=:any ModelingToolkit.eliminate_perfect_aliases!(state) |
Contributor
There was a problem hiding this comment.
[Runic] reported by reviewdog 🐶
Suggested change
| @test_logs (:warn, r"state_priority") match_mode=:any ModelingToolkit.eliminate_perfect_aliases!(state) | |
| @test_logs (:warn, r"state_priority") match_mode = :any ModelingToolkit.eliminate_perfect_aliases!(state) |
| # Exactly one of the two variables is eliminated as observed. | ||
| n_elim = count( | ||
| eq -> isequal(eq.lhs, unwrap(x)) || isequal(eq.lhs, unwrap(y)), | ||
| state.additional_observed) |
Contributor
There was a problem hiding this comment.
[Runic] reported by reviewdog 🐶
Suggested change
| state.additional_observed) | |
| state.additional_observed | |
| ) |
Contributor
Benchmark Results (Julia vlts)Time benchmarks
Memory benchmarks
|
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
…inate_perfect_aliases!` Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
AayushSabharwal
force-pushed
the
as/perfect-aliases-positive-priority
branch
from
2f3ce8f to
65f04db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following from the discussion in JuliaComputing/StateSelection.jl#103