Skip to content

GPU porting of SourceTerms#284

Merged
EmilyBourne merged 6 commits into
mainfrom
ebourne_gradual_gpu_port_part_2
May 29, 2026
Merged

GPU porting of SourceTerms#284
EmilyBourne merged 6 commits into
mainfrom
ebourne_gradual_gpu_port_part_2

Conversation

@EmilyBourne
Copy link
Copy Markdown
Collaborator

To rebase and merge after #278

Merge Request - GuideLine Checklist

Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.

Checks by code author:

Always to be checked:

  • There is at least one issue associated with the pull request.
  • New code adheres with the coding guidelines
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

If functions were changed or functionality was added:

  • Tests for new functionality has been added
  • A local test was succesful

If new functionality was added:

  • There is appropriate documentation of your work. (use doxygen style comments)

If new third party software is used:

  • Did you pay attention to its license? Please remember to add it to the wiki after successful merging.

If new mathematical methods or epidemiological terms are used:

  • Are new methods referenced? Did you provide further documentation?

Checks by code reviewer(s):

  • Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
  • The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
  • There are appropriate unit tests and they pass.
  • The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
  • Coverage report for new code is acceptable.
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

@EmilyBourne
Copy link
Copy Markdown
Collaborator Author

On v100 at ebdf00e:
Without MUMPS:

100% tests passed, 0 tests failed out of 496

With MUMPS:

100% tests passed, 0 tests failed out of 500

@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.78%. Comparing base (138b597) to head (56a4d64).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #284   +/-   ##
=======================================
  Coverage   95.78%   95.78%           
=======================================
  Files          79       79           
  Lines        8634     8638    +4     
=======================================
+ Hits         8270     8274    +4     
  Misses        364      364           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from ebourne_gradual_gpu_port_part_1 to main May 29, 2026 13:03
@EmilyBourne EmilyBourne force-pushed the ebourne_gradual_gpu_port_part_2 branch from 65620b4 to 56a4d64 Compare May 29, 2026 13:45
@EmilyBourne EmilyBourne requested a review from julianlitz May 29, 2026 14:33
Copy link
Copy Markdown
Collaborator

@julianlitz julianlitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@EmilyBourne EmilyBourne merged commit 37605a8 into main May 29, 2026
9 checks passed
@EmilyBourne EmilyBourne deleted the ebourne_gradual_gpu_port_part_2 branch May 29, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants