Skip to content

Conversation

@julianlitz
Copy link
Collaborator

@julianlitz julianlitz commented Jan 16, 2026

Renamed DirectSolver classes to make their purpose and implementation clearer:

  • DirectSolverGive -> DirectSolver_COO_MUMPS_Give
  • DirectSolverTake -> DirectSolver_COO_MUMPS_Take
  • DirectSolverGiveCustomLU -> DirectSolver_CSR_LU_Give
  • DirectSolverTakeCustomLU -> DirectSolver_CSR_LU_Take

These new names explicitly indicate:

  • The matrix storage format (COO or CSR)
  • The solver algorithm (MUMPS or LU)
  • The stencil operation mode (Give or Take)

This change improves readability and helps developers quickly identify the solver type and behavior.

Merge Request - GuideLine Checklist

Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.

Checks by code author:

Always to be checked:

  • There is at least one issue associated with the pull request.
  • New code adheres with the coding guidelines
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

If functions were changed or functionality was added:

  • Tests for new functionality has been added
  • A local test was succesful

If new functionality was added:

  • There is appropriate documentation of your work. (use doxygen style comments)

If new third party software is used:

  • Did you pay attention to its license? Please remember to add it to the wiki after successful merging.

If new mathematical methods or epidemiological terms are used:

  • Are new methods referenced? Did you provide further documentation?

Checks by code reviewer(s):

  • Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
  • The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
  • There are appropriate unit tests and they pass.
  • The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
  • Coverage report for new code is acceptable.
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

❌ Patch coverage is 96.29630% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.67%. Comparing base (05c809e) to head (fe4579d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...tSolver/DirectSolver-CSR-LU-Give/matrixStencil.cpp 66.66% 1 Missing ⚠️
...tSolver/DirectSolver-CSR-LU-Take/matrixStencil.cpp 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #155   +/-   ##
=======================================
  Coverage   88.67%   88.67%           
=======================================
  Files          87       87           
  Lines        4982     4982           
=======================================
  Hits         4418     4418           
  Misses        564      564           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@julianlitz julianlitz merged commit c547dfa into main Jan 16, 2026
8 checks passed
@julianlitz julianlitz deleted the litz_improve_class_names branch January 16, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants