Skip to content

Allow creating new position folders data struct, see #750#995

Merged
ElpadoCan merged 4 commits intomainfrom
implements_750
Apr 2, 2026
Merged

Allow creating new position folders data struct, see #750#995
ElpadoCan merged 4 commits intomainfrom
implements_750

Conversation

@ElpadoCan
Copy link
Copy Markdown
Collaborator

This PR adds a checkpoint to the data structure module where, if position folders already exist in the destination folder, the user will have the possibility to choose to create new Position folders in addition to overwriting or adding files to existing position folders.

This implements #750

@Teranis
Copy link
Copy Markdown
Member

Teranis commented Mar 23, 2026

Not related to the changes here, but maybe we should address this in this PR:
If I select a folder with several raw files, it asks which one should be selected, but pressing ok just ends the process:
Closing data structure logger...

@ElpadoCan
Copy link
Copy Markdown
Collaborator Author

Not related to the changes here, but maybe we should address this in this PR: If I select a folder with several raw files, it asks which one should be selected, but pressing ok just ends the process: Closing data structure logger...

You mean when selecting "Single microscopy file with multiple positions" and then selecting a folder that contains more than one file?

@Teranis
Copy link
Copy Markdown
Member

Teranis commented Mar 25, 2026

I am not entirely sure why (whether it has to do with the conversion itself or this new feature), but for me, after confirming the metadata, it instantly finishes, and no new Pos folders are added, sadly. No error msg

(For completeness reasons, since I put it in the wrong PR 🙃

@ElpadoCan
Copy link
Copy Markdown
Collaborator Author

We need to test adding positions using the "Single microscopy file with multiple positions" option.

Adding Positions with this option should go through a warning because the user is potentially merging different experiments.

@Teranis
Copy link
Copy Markdown
Member

Teranis commented Mar 26, 2026

Will close #73

@ElpadoCan
Copy link
Copy Markdown
Collaborator Author

The last commit fixes the bug that was preventing creating additional new Positions with the option "Single microscopy file with multiple positions"

Copy link
Copy Markdown
Member

@Teranis Teranis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! (sorry didn't see that it needed my approval, also tested again to be sure)

@ElpadoCan ElpadoCan merged commit e265bc3 into main Apr 2, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants