Skip to content

Add domain validation#5640

Open
ya7010 wants to merge 1 commit intoSchemaStore:masterfrom
ya7010:add_domain_validation
Open

Add domain validation#5640
ya7010 wants to merge 1 commit intoSchemaStore:masterfrom
ya7010:add_domain_validation

Conversation

@ya7010
Copy link
Copy Markdown
Contributor

@ya7010 ya7010 commented Apr 30, 2026

Related: #5621

Prohibit the use of the json.schemastore.org domain and recommend the use of www.schemastore.org instead.

To pass CI for this PR, we need to merge #5626 first.

@github-actions github-actions Bot added WARNING_WebsiteFiles AspNetFiles is updated (auto-generated by labeler action) cli.js Changes to the build system / JavaScript. labels Apr 30, 2026
@ya7010 ya7010 force-pushed the add_domain_validation branch from a6db8a0 to 5862062 Compare April 30, 2026 10:49
@github-actions github-actions Bot removed the WARNING_WebsiteFiles AspNetFiles is updated (auto-generated by labeler action) label Apr 30, 2026
@madskristensen
Copy link
Copy Markdown
Contributor

this is a great idea, but the issue is that the current $id property URLs must not change and they have to remain using json.. But perhaps we can limit it to new files or to $ref URLs instead?

@ya7010
Copy link
Copy Markdown
Contributor Author

ya7010 commented Apr 30, 2026

Conceptually, I understand that the $id should not be changed, but in practice, json.schemastore.org redirects to www.schemastore.org.

What are some potential drawbacks of changing the $id?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli.js Changes to the build system / JavaScript.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants