fix(schema): resolve linting issues in abc-supply-plan schemas#5283
fix(schema): resolve linting issues in abc-supply-plan schemas#5283Vaibhav701161 wants to merge 2 commits intoSchemaStore:masterfrom
Conversation
|
Thanks for the PR! This section of the codebase is owned by @madskristensen and |
for more information, see https://pre-commit.ci
|
The failing check is as an unknown keyword is appended with the keyword "x-", see https://github.com/orgs/json-schema-org/discussions/329 |
|
I worry that prepending |
|
JSON Schema TSC here 👋🏻 We actively discourage the use of AJV given these compliance issues, as the confusion they introduce (like this one) actively harms the ecosystem. That said, I get @hyperupcall 's concerns. @Vaibhav701161 maybe try to fix this properly on AJV? Sending a PR with Claude/Codex might not be very hard! |
|
@jviotti I’ll raise an issue and work on a PR on the Ajv side to see if their strict mode handling can be improved. |
|
Sounds good. If any, their strict mode shouldn't allow you to use |
Fixed JSON schema linting issues in the
abc-supply-planschemas for versions:The changes bring the schemas into compliance with SchemaStore linting rules without altering their intended structure or semantics.
Before and after:
*
abc-supply-plan-1.0.0 :abc.supply.1.0.0.mp4
*
abc-supply-plan-2.0.0 :abc.supply.2.0.0.mp4
*
abc-supply-plan-3.0.0 :abc.supply.3.0.0.mp4
Note: This PR was created with the help of jsonschema cli, created by a member of TSC of JSON Schema committee. The extension used is based on the same cli