Skip to content

fix(schema): resolve linting issues in abc-supply-plan schemas#5283

Closed
Vaibhav701161 wants to merge 2 commits intoSchemaStore:masterfrom
Vaibhav701161:fix/schema-linting-abc
Closed

fix(schema): resolve linting issues in abc-supply-plan schemas#5283
Vaibhav701161 wants to merge 2 commits intoSchemaStore:masterfrom
Vaibhav701161:fix/schema-linting-abc

Conversation

@Vaibhav701161
Copy link
Copy Markdown
Contributor

Fixed JSON schema linting issues in the abc-supply-plan schemas for versions:

  • 1.0.0
  • 2.0.0
  • 3.0.0

The changes bring the schemas into compliance with SchemaStore linting rules without altering their intended structure or semantics.

  • Normalized formatting and ordering
  • Fixed lint violations reported by the schema linter
  • No functional or breaking changes introduced

Before and after:

*abc-supply-plan-1.0.0 :

abc.supply.1.0.0.mp4

*abc-supply-plan-2.0.0 :

abc.supply.2.0.0.mp4

*abc-supply-plan-3.0.0 :

abc.supply.3.0.0.mp4

Note: This PR was created with the help of jsonschema cli, created by a member of TSC of JSON Schema committee. The extension used is based on the same cli

@github-actions
Copy link
Copy Markdown
Contributor

Thanks for the PR!

This section of the codebase is owned by @madskristensen and @hyperupcall - if they write a comment saying "LGTM" then it will be merged.

@Vaibhav701161
Copy link
Copy Markdown
Contributor Author

The failing check is as an unknown keyword is appended with the keyword "x-", see https://github.com/orgs/json-schema-org/discussions/329

@hyperupcall
Copy link
Copy Markdown
Member

I worry that prepending x- to various properties is a breaking change to some clients, even if it does not directly comply with the standard.

@jviotti
Copy link
Copy Markdown
Contributor

jviotti commented Feb 22, 2026

JSON Schema TSC here 👋🏻 We actively discourage the use of AJV given these compliance issues, as the confusion they introduce (like this one) actively harms the ecosystem. That said, I get @hyperupcall 's concerns. @Vaibhav701161 maybe try to fix this properly on AJV? Sending a PR with Claude/Codex might not be very hard!

@Vaibhav701161
Copy link
Copy Markdown
Contributor Author

@jviotti I’ll raise an issue and work on a PR on the Ajv side to see if their strict mode handling can be improved.

@jviotti
Copy link
Copy Markdown
Contributor

jviotti commented Feb 22, 2026

Sounds good. If any, their strict mode shouldn't allow you to use deprecated if its not on a dialect where that keyword has actually being defined. I think they do the same with other keywords too, like $defs, allowing it in other dialects too. So its almost like the support some strange union of all dialects at the same time or something like that, which throws people off when they want to use the schemas with another implementation in another system: the other side won't take them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants