Fix free slicer#3970
Open
jellybean2004 wants to merge 7 commits into
Open
Conversation
8 tasks
Comment on lines
+304
to
+306
| # Notify the slicer parameters dialog (if open) so its list stays in sync | ||
| if (slicer_widget := getattr(self, 'slicer_widget', None)): | ||
| slicer_widget.updateSlicersList() |
Comment on lines
+384
to
+387
| # Notify the slicer parameters dialog (if open) so its list stays in sync | ||
| if (slicer_widget := getattr(self, 'slicer_widget', None)): | ||
| slicer_widget.updateSlicersList() | ||
|
|
Contributor
|
Some of the test failures are fixed with #3961; they may need an update to the newest sasmodels as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This patch fixes an issue where closing a 1D slicer plot could leave its associated slicer visible on the original 2D plot, causing it to behave incorrectly when moved.
PlotterDataobjects using a weak reference to the owning 2D plot.Plotter2Dto remove all slicers associated with the closed 1D plot window.The BoxSum (which does not have a plot but a widget) also closes cleanly with its widget, so the associated slicer is removed too.
Fixes #3969
How Has This Been Tested?
Manually tested in build and added tests
Review Checklist:
Documentation
Installers
Licensing