Refactor operations #184
Refactor operations #184
Conversation
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
rprospero
left a comment
rprospero
left a comment
There was a problem hiding this comment.
Looks good, but sasdata/transforms/operation.py seems to be redundant, unless I'm missing something
sasdata/transforms/operation.py
Outdated
| from sasdata.quantities.quantity import Quantity | ||
|
|
||
|
|
||
| class Operation: |
There was a problem hiding this comment.
I might be dense, but this seems to be a duplicate of the Operation class in sasdata/quantities/quantity.py. Do we need this class?
There was a problem hiding this comment.
This was included in the original branch which is why I left it in, but looking at it now I agree with you that it can be removed.
DrPaulSharp
force-pushed
the
86-exponental-and-trig-functions-into-history
branch
from
c8ae0ac to
6aea9e1
Compare
There was a problem hiding this comment.
No quality gates enabled for this code.
See analysis details in CodeScene
Quality Gate Profile: Custom Configuration
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
3 participants
This PR refactors the operations code and adds tests, in preparation for adding exponential and trig functions (the original branch added only Log and Ln).
Note that many of the changes arise from ruff formatting, but these are only applied in the last commit, going up to the penultimate commit will show all of the functional code changes.