Replace lock-based stats with Interlocked in MemoryPluginCache#37
Merged
Conversation
Using Interlocked.Increment/Read instead of lock(_statsLock) removes unnecessary contention on the hot path. Cache hit/miss counters are simple atomic increments that don't need mutual exclusion with other state.
Sarmkadan
commented
May 21, 2026
Owner
Author
Sarmkadan
left a comment
Sarmkadan
left a comment
There was a problem hiding this comment.
Straightforward improvement. The Interlocked operations are correct here since hits and misses are independent counters - no need for compound atomicity.
Sarmkadan
commented
May 21, 2026
Owner
Author
Sarmkadan
left a comment
Sarmkadan
left a comment
There was a problem hiding this comment.
Straightforward improvement. The Interlocked operations are correct here since hits and misses are independent counters - no need for compound atomicity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
MemoryPluginCacheuseslock(_statsLock)for simple counter increments on the cache hit/miss hot path. This creates unnecessary contention when multiple threads access the cache concurrently.Solution: Replace
lockblocks withInterlocked.Incrementfor counter updates andInterlocked.Readfor statistics retrieval. Remove the_statsLockobject entirely.This is a zero-allocation, lock-free improvement that reduces contention without changing behavior.