Add CI workflow and configuration for SampSharp Docker image#1
Open
bssth wants to merge 1 commit intoSampSharp:mainfrom
Open
Add CI workflow and configuration for SampSharp Docker image#1bssth wants to merge 1 commit intoSampSharp:mainfrom
bssth wants to merge 1 commit intoSampSharp:mainfrom
Conversation
Member
|
The user needs a Docker image that includes:
Ideally, we wouldn’t lock users into specific open.mp or .NET versions. However, open.mp releases are not as frequent as .NET, and obtaining an x64 build can be cumbersome. To simplify things, it’s preferable to provide an image containing open.mp and sampsharp, allowing users to layer in their preferred .NET runtime. A typical Dockerfile for users could look like: FROM <sampsharp> as sampsharp
FROM mcr.microsoft.com/dotnet/runtime:10.0 as runtime
# TODO: may need a few dependencies for open.mp?
COPY --from=sampsharp /server /server
COPY ./gamemode/ /server/gamemode
COPY ./config.json /server/config.json
# TODO: define ENTRYPOINT/CMD |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've created two versions - one with open.mp (which you can run directly on your code) and one without (which you can use as a scratch for your own image). Let me know if you don't like this approach
ikkentim/SampSharp#467