Fix name overrides for constructed types#552
Merged
SamboyCoding merged 1 commit intoJun 7, 2026
Merged
Conversation
Contributor
ds5678
commented
May 17, 2026
ds5678
commented
- Ensure that DefaultName only calls DefaultName and DefaultFullName, not Name or FullName
- Remove unnecessary ReferenceTypeAnalysisContext::ToString override
- Seal Type and name properties
- Use DefaultFullName and FullName for arguments of GenericInstanceTypeAnalysisContext to ensure expected output from its own DefaultFullName and FullName
Coverage Report for CI Build 27101739479Warning No base build found for commit Coverage: 33.825%Details
Uncovered Changes
Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
SamboyCoding
approved these changes
Jun 7, 2026
Owner
|
Can't push to your fork, can't resolve conflicts and merge this. |
* Ensure that DefaultName only calls DefaultName and DefaultFullName, not Name or FullName * Remove unnecessary ReferenceTypeAnalysisContext::ToString override * Seal Type and name properties * Use DefaultFullName and FullName for arguments of GenericInstanceTypeAnalysisContext to ensure expected output from its own DefaultFullName and FullName
ds5678
force-pushed
the
fix-name-overrides
branch
from
d03ec7d to
3be2901
Compare
SamboyCoding
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.