Add ACME profile support for IP address certificates#3958
Open
nekohasekai wants to merge 9 commits intotestingfrom
Open
Add ACME profile support for IP address certificates#3958nekohasekai wants to merge 9 commits intotestingfrom
nekohasekai wants to merge 9 commits intotestingfrom
Conversation
Auto-select `shortlived` profile for Let's Encrypt when domain list contains IP addresses. Expose `profile` option to allow manual override for custom CA servers.
Replace certmagic with a fork that strips brackets from bare IPv6 addresses in the HTTP Host header, fixing HTTP-01 challenge matching for IPv6 literal address certificates. Fixes #3964
nekohasekai
force-pushed
the
fix-acme-http-tls-challenge
branch
from
6342fb3 to
4143800
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shortlivedACME profile for Let's Encrypt when domain list contains IP addresses, fixingrejectedIdentifiererrorsprofileoption for manual override (custom CA servers)Test plan
profilefield and verify it takes precedence over auto-detection