Fix dispatch ambiguities by restricting aud to audgz (d>0:shp)#255
Open
rubenhensen wants to merge 1 commit intoSacBase:masterfrom
Open
Fix dispatch ambiguities by restricting aud to audgz (d>0:shp)#255rubenhensen wants to merge 1 commit intoSacBase:masterfrom
rubenhensen wants to merge 1 commit intoSacBase:masterfrom
Conversation
Replace [d:shp] with [d>0:shp] in commutative overload pairs where one function was more specific in one arg position but less specific in another, causing the new dispatch rule to reject them. - Quaternion.xsac: * operator scalar×aud / aud×scalar overloads - arraybasics.mac: MODARRAY_AxVxS conflicting with MODARRAY_AxSxA - ArrayTransform.xsac: WHERE AxS / SxA overloads - ComplexArrayArith.xsac: MAP_BIN AxS / SxA overloads
sbscholz
reviewed
Apr 14, 2026
| } | ||
|
|
||
| #define MODARRAY_AxVxS(typ, _postfix, _fmt, _zval, _oval) \ | ||
| inline typ[d:shp] modarray(typ[d:shp] arr, int[d] idx, typ val) \ |
Member
There was a problem hiding this comment.
why do we have to exclude the scalar case?
I think we have [*] [.] [*] , [*] [.] [], and [.,*] [] [*]. which should be ok to coexist, no?!
| #define WHERE_AxA(typ, _postfix, _fmt, _zval, _oval) \ | ||
| inline \ | ||
| typ[d:shp] where(bool[d:shp] p, typ[d:shp] A, typ[d:shp] B) \ | ||
| typ[d>0:shp] where(bool[d>0:shp] p, typ[d>0:shp] A, typ[d>0:shp] B) \ |
Member
There was a problem hiding this comment.
I think we should add a 4th implementation that caters for the "all scalar" case. we could implement that by a normal conditional....
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace [d:shp] with [d>0:shp] in commutative overload pairs where one function was more specific in one arg position but less specific in another, causing the new dispatch rule to reject them.
Has to do with: https://gitlab.sac-home.org/sac-group/sac2c/-/merge_requests/637