Update macro usage to reflect changed macro's for slice support#254
Merged
sbscholz merged 1 commit intoSacBase:masterfrom Apr 9, 2026
Merged
Update macro usage to reflect changed macro's for slice support#254sbscholz merged 1 commit intoSacBase:masterfrom
sbscholz merged 1 commit intoSacBase:masterfrom
Conversation
MdeBoerBlazdell
changed the title
sbscholz
approved these changes
Apr 9, 2026
Member
sbscholz
left a comment
sbscholz
left a comment
There was a problem hiding this comment.
This all looks fine just moving the descriptor allocations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To add support for slice operations, we need to extend the descriptors slightly. In particular, each descriptor is extended by the data that it describes. This pull request reorders some usages of macro's that will be changed to support slicing to ensure that they correctly update the extended descriptors