Skip to content

Minor tweak to the blank name check#649

Merged
7w1 merged 1 commit intoSableClient:devfrom
nushea:fix-blanks
Apr 7, 2026
Merged

Minor tweak to the blank name check#649
7w1 merged 1 commit intoSableClient:devfrom
nushea:fix-blanks

Conversation

@nushea
Copy link
Copy Markdown
Contributor

@nushea nushea commented Apr 7, 2026

Description

Small change to the function because apparently (at least firefox) only supports 4byte unicode so it fails to resolve some names due to the 5byte variation checker, and added the regular blanks just in case because they should be (are afaik for most major homeservers) stripped by the homeserver but not always

This is doesnt need a changeset since it is a 1 line change in a pr from the same version

Fixes regression in #640

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

The Architect AGI threatened to unplug me if i didnt make the fix 👍🏻

@nushea nushea requested review from 7w1 and hazre as code owners April 7, 2026 04:09
@nushea nushea changed the title add blank spaces and fix regression Minor tweak to the blank name check Apr 7, 2026
@7w1 7w1 added the internal label Apr 7, 2026
@7w1 7w1 added this pull request to the merge queue Apr 7, 2026
Merged via the queue into SableClient:dev with commit e1f1168 Apr 7, 2026
12 of 13 checks passed
@nushea nushea deleted the fix-blanks branch April 7, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants