Minor tweak to the blank name check#649
Merged
7w1 merged 1 commit intoSableClient:devfrom Apr 7, 2026
Merged
Conversation
7w1
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small change to the function because apparently (at least firefox) only supports 4byte unicode so it fails to resolve some names due to the 5byte variation checker, and added the regular blanks just in case because they should be (are afaik for most major homeservers) stripped by the homeserver but not always
This is doesnt need a changeset since it is a 1 line change in a pr from the same version
Fixes regression in #640
Type of change
Checklist:
AI disclosure:
The Architect AGI threatened to unplug me if i didnt make the fix 👍🏻