Skip to content

Add support for displaying bundled previews MSC4095#590

Merged
7w1 merged 5 commits intoSableClient:devfrom
nushea:msc4095
Apr 6, 2026
Merged

Add support for displaying bundled previews MSC4095#590
7w1 merged 5 commits intoSableClient:devfrom
nushea:msc4095

Conversation

@nushea
Copy link
Copy Markdown
Contributor

@nushea nushea commented Mar 29, 2026

Description

This PR wishes to display bundled previews, should they be offered, in order to align to MSC4095.

Implements: matrix-org/matrix-spec-proposals#4095

Also i swear i didnt modify anything past line 75 in /src/app/components/url-preview/UrlPreviewCart.tsx i just added a param to UrlPreviewCard which pushed the length over the limit breaking the params into a table format, which then put the closing angle bracket right before the arguments which then made it no longer take one indentation which pushed the entire code to have one less indentation for prettier and if i am to change anything meaninglessly it just reverts it 😭

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

A Jihn waswasa-ed the implementation to me.

@nushea nushea requested review from 7w1 and hazre as code owners March 29, 2026 21:47
@nushea nushea changed the title Add support for displaying bundled previews Add support for displaying bundled previews MSC4095 Mar 29, 2026
Copy link
Copy Markdown
Member

@7w1 7w1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm but i have not tested

@7w1
Copy link
Copy Markdown
Member

7w1 commented Apr 6, 2026

conflicts D:

@nushea
Copy link
Copy Markdown
Contributor Author

nushea commented Apr 6, 2026

conflicts D:

dont seem to be major conflicts at all, ill fix them in some 2 hours (after work)

@nushea
Copy link
Copy Markdown
Contributor Author

nushea commented Apr 6, 2026

merge has ben waswasaed

@7w1 7w1 added this pull request to the merge queue Apr 6, 2026
Merged via the queue into SableClient:dev with commit e78e97f Apr 6, 2026
12 checks passed
@nushea nushea deleted the msc4095 branch April 6, 2026 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants