Skip to content

Bug/fix venc cabac int type #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
svogl wants to merge 3 commits into from
Closed

Bug/fix venc cabac int type #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5103ccb
fixed typo wrt hw handshake
svogl Feb 24, 2026
5b75826
linker script: adjust absolute windows path to project-relative
svogl Feb 24, 2026
d6b339c
fix integer type to prevent compile error
svogl Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Middlewares/Third_Party/VideoEncoder/source/h264/H264CabacContext.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
/* m and n values for given CtxIdx */

/* I Slices */
static const int h264ContextInitIntra[460][2] = {
static const i32 h264ContextInitIntra[460][2] = {
/* 0 -> 10 */
{20, -15}, {2, 54}, {3, 74}, {20, -15},
{2, 54}, {3, 74}, {-28, 127}, {-23, 104},
Expand Down
2 changes: 1 addition & 1 deletion Projects/STM32N6570-DK/Applications/VENC/VENC_RTSP_Server/Appli/Core/Inc/venc_h264_config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ uint8_t *GetInputFrame(uint32_t *framSize);
* @brief Return whether hardware handshake (slice/stream) mode is active.
* @retval bool true if hw handshake mode enabled.
*/
bool IsHwHanshakeMode(void);
bool IsHwHandshakeMode(void);

/**
* @brief Get DCMIPP pixel packer format id used by the pipeline.
Expand Down
2 changes: 1 addition & 1 deletion Projects/STM32N6570-DK/Applications/VENC/VENC_RTSP_Server/Appli/Core/Src/dcmipp_app.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ HAL_StatusTypeDef MX_DCMIPP_Init(DCMIPP_HandleTypeDef *hdcmipp)
if (ret == HAL_OK)
{
/* Specific Hardware Handshake if needed*/
if (IsHwHanshakeMode())
if (IsHwHandshakeMode())
{
ret = dcmipp_enable_HW_Handshake(hdcmipp);
}
Expand Down
2 changes: 1 addition & 1 deletion Projects/STM32N6570-DK/Applications/VENC/VENC_RTSP_Server/Appli/Core/Src/venc_app.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ bool IsVideoOverflow(void)
{
bool videoOverflow = false;

if (IsHwHanshakeMode())
if (IsHwHandshakeMode())
{
videoOverflow = (nbLineEvent != 0U);
}
Expand Down
6 changes: 3 additions & 3 deletions Projects/STM32N6570-DK/Applications/VENC/VENC_RTSP_Server/Appli/Core/Src/venc_h264_config.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ uint32_t GetNbInputFrame(void)
* @brief Return whether hardware handshake (slice/stream) mode is enabled.
* @retval true if HW handshake mode enabled, false otherwise.
*/
bool IsHwHanshakeMode(void)
bool IsHwHandshakeMode(void)
{
#if (VENC_HW_MODE_ENABLE == 1U)
return true;
Expand Down Expand Up @@ -297,7 +297,7 @@ HAL_StatusTypeDef GetDCMIPPLinesConfig(uint32_t *pWarpLines, uint32_t *pIrqLines
uint32_t nbLinesCaptured = VENC_LINE_BUF_DEPTH * CAM_MACROBLOCK_HEIGHT;
HAL_StatusTypeDef ret = HAL_OK;

if (!IsHwHanshakeMode())
if (!IsHwHandshakeMode())
{
return HAL_ERROR;
}
Expand Down Expand Up @@ -335,7 +335,7 @@ HAL_StatusTypeDef GetDCMIPPLinesConfig(uint32_t *pWarpLines, uint32_t *pIrqLines
uint32_t GetDCMIPPNbLinesCaptured(void)
{
/* In hardware handshake mode, capture N lines within a 2*N buffer */
if (IsHwHanshakeMode())
if (IsHwHandshakeMode())
{
return (uint32_t)(2U * VENC_LINE_BUF_DEPTH * CAM_MACROBLOCK_HEIGHT);
}
Expand Down
2 changes: 1 addition & 1 deletion ...cts/STM32N6570-DK/Applications/VENC/VENC_SDCard_ThreadX/Appli/Core/Inc/venc_h264_config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ uint8_t * GetInputFrame(uint32_t * framSize);
* @brief Return whether hardware handshake (slice/stream) mode is active.
* @retval bool true if hw handshake mode enabled.
*/
bool IsHwHanshakeMode(void);
bool IsHwHandshakeMode(void);

/**
* @brief Get DCMIPP pixel packer format id used by the pipeline.
Expand Down
2 changes: 1 addition & 1 deletion Projects/STM32N6570-DK/Applications/VENC/VENC_SDCard_ThreadX/Appli/Core/Src/dcmipp_app.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ HAL_StatusTypeDef MX_DCMIPP_Init(DCMIPP_HandleTypeDef *hdcmipp)
if (ret == HAL_OK)
{
/* Specific Hardware Handshake if needed*/
if (IsHwHanshakeMode())
if (IsHwHandshakeMode())
{
ret = dcmipp_enable_HW_Handshake(hdcmipp);
}
Expand Down
2 changes: 1 addition & 1 deletion Projects/STM32N6570-DK/Applications/VENC/VENC_SDCard_ThreadX/Appli/Core/Src/venc_app.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ bool IsVideoOverflow(void)
{
bool videoOverflow = false;

if (IsHwHanshakeMode())
if (IsHwHandshakeMode())
{
videoOverflow = (nbLineEvent != 0U);
}
Expand Down
6 changes: 3 additions & 3 deletions ...cts/STM32N6570-DK/Applications/VENC/VENC_SDCard_ThreadX/Appli/Core/Src/venc_h264_config.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ uint32_t GetNbInputFrame(void)
* @brief Return whether hardware handshake (slice/stream) mode is enabled.
* @retval true if HW handshake mode enabled, false otherwise.
*/
bool IsHwHanshakeMode(void)
bool IsHwHandshakeMode(void)
{
#if (VENC_HW_MODE_ENABLE == 1U)
return true;
Expand Down Expand Up @@ -286,7 +286,7 @@ HAL_StatusTypeDef GetDCMIPPLinesConfig(uint32_t *pWarpLines, uint32_t *pIrqLines
uint32_t nbLinesCaptured = VENC_LINE_BUF_DEPTH * CAM_MACROBLOCK_HEIGHT;
HAL_StatusTypeDef ret = HAL_OK;

if (!IsHwHanshakeMode())
if (!IsHwHandshakeMode())
{
return HAL_ERROR;
}
Expand Down Expand Up @@ -324,7 +324,7 @@ HAL_StatusTypeDef GetDCMIPPLinesConfig(uint32_t *pWarpLines, uint32_t *pIrqLines
uint32_t GetDCMIPPNbLinesCaptured(void)
{
/* In hardware handshake mode, capture N lines within a 2*N buffer */
if (IsHwHanshakeMode())
if (IsHwHandshakeMode())
{
return (uint32_t)(2U * VENC_LINE_BUF_DEPTH * CAM_MACROBLOCK_HEIGHT);
}
Expand Down
4 changes: 2 additions & 2 deletions Projects/STM32N6570-DK/Applications/VENC/VENC_SDCard_ThreadX/STM32CubeIDE/Appli/.cproject
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
<option id="com.st.stm32cube.ide.mcu.gnu.managedbuild.tool.cpp.compiler.option.optimization.level.417448642" name="Optimization level" superClass="com.st.stm32cube.ide.mcu.gnu.managedbuild.tool.cpp.compiler.option.optimization.level" useByScannerDiscovery="false"/>
</tool>
<tool id="com.st.stm32cube.ide.mcu.gnu.managedbuild.tool.c.linker.1849438250" name="MCU GCC Linker" superClass="com.st.stm32cube.ide.mcu.gnu.managedbuild.tool.c.linker">
<option id="com.st.stm32cube.ide.mcu.gnu.managedbuild.tool.c.linker.option.script.93089147" name="Linker Script (-T)" superClass="com.st.stm32cube.ide.mcu.gnu.managedbuild.tool.c.linker.option.script" value="C:\git\n6\STM32Cube_FW_N6_V1.3.0_Ext_Refact\Projects\STM32N6570-DK\Applications\VENC\VENC_SDCard_ThreadX\STM32CubeIDE\Appli\STM32N657XX.ld" valueType="string"/>
<option id="com.st.stm32cube.ide.mcu.gnu.managedbuild.tool.c.linker.option.script.93089147" name="Linker Script (-T)" superClass="com.st.stm32cube.ide.mcu.gnu.managedbuild.tool.c.linker.option.script" value="${workspace_loc:/${ProjName}/STM32N657XX.ld}" valueType="string"/>
<option IS_BUILTIN_EMPTY="false" IS_VALUE_EMPTY="true" id="com.st.stm32cube.ide.mcu.gnu.managedbuild.tool.c.linker.option.otherflags.113829423" name="Other flags" superClass="com.st.stm32cube.ide.mcu.gnu.managedbuild.tool.c.linker.option.otherflags" valueType="stringList"/>
<option IS_BUILTIN_EMPTY="false" IS_VALUE_EMPTY="false" id="com.st.stm32cube.ide.mcu.gnu.managedbuild.tool.c.linker.option.directories.1500726823" name="Library search path (-L)" superClass="com.st.stm32cube.ide.mcu.gnu.managedbuild.tool.c.linker.option.directories" valueType="libPaths">
<listOptionValue builtIn="false" value="../../../../../../../../Middlewares/ST/STM32_ISP_Library/evision/Lib"/>
Expand Down Expand Up @@ -251,4 +251,4 @@
</configuration>
</storageModule>
<storageModule moduleId="org.eclipse.cdt.make.core.buildtargets"/>
</cproject>
</cproject>
2 changes: 1 addition & 1 deletion Projects/STM32N6570-DK/Applications/VENC/VENC_USB/Appli/Core/Inc/venc_h264_config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ uint8_t * GetInputFrame(uint32_t * framSize);
* @brief Return whether hardware handshake (slice/stream) mode is active.
* @retval bool true if hw handshake mode enabled.
*/
bool IsHwHanshakeMode(void);
bool IsHwHandshakeMode(void);

/**
* @brief Get DCMIPP pixel packer format id used by the pipeline.
Expand Down
2 changes: 1 addition & 1 deletion Projects/STM32N6570-DK/Applications/VENC/VENC_USB/Appli/Core/Src/dcmipp_app.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ HAL_StatusTypeDef MX_DCMIPP_Init(DCMIPP_HandleTypeDef *hdcmipp)
if (ret == HAL_OK)
{
/* Specific Hardware Handshake if needed*/
if (IsHwHanshakeMode())
if (IsHwHandshakeMode())
{
ret = dcmipp_enable_HW_Handshake(hdcmipp);
}
Expand Down
2 changes: 1 addition & 1 deletion Projects/STM32N6570-DK/Applications/VENC/VENC_USB/Appli/Core/Src/venc_app.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ bool IsVideoOverflow(void)
{
bool videoOverflow = false;

if (IsHwHanshakeMode())
if (IsHwHandshakeMode())
{
videoOverflow = (nbLineEvent != 0U);
}
Expand Down
6 changes: 3 additions & 3 deletions Projects/STM32N6570-DK/Applications/VENC/VENC_USB/Appli/Core/Src/venc_h264_config.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ uint32_t GetNbInputFrame(void)
* @brief Return whether hardware handshake (slice/stream) mode is enabled.
* @retval true if HW handshake mode enabled, false otherwise.
*/
bool IsHwHanshakeMode(void)
bool IsHwHandshakeMode(void)
{
#if (VENC_HW_MODE_ENABLE == 1U)
return true;
Expand Down Expand Up @@ -293,7 +293,7 @@ HAL_StatusTypeDef GetDCMIPPLinesConfig(uint32_t *pWarpLines, uint32_t *pIrqLines
uint32_t nbLinesCaptured = VENC_LINE_BUF_DEPTH * CAM_MACROBLOCK_HEIGHT;
HAL_StatusTypeDef ret = HAL_OK;

if (!IsHwHanshakeMode())
if (!IsHwHandshakeMode())
{
return HAL_ERROR;
}
Expand Down Expand Up @@ -331,7 +331,7 @@ HAL_StatusTypeDef GetDCMIPPLinesConfig(uint32_t *pWarpLines, uint32_t *pIrqLines
uint32_t GetDCMIPPNbLinesCaptured(void)
{
/* In hardware handshake mode, capture N lines within a 2*N buffer */
if (IsHwHanshakeMode())
if (IsHwHandshakeMode())
{
return (uint32_t)(2U * VENC_LINE_BUF_DEPTH * CAM_MACROBLOCK_HEIGHT);
}
Expand Down