Skip to content

[Improve] attribute reading#61

Closed
samatstariongroup wants to merge 5 commits intodevelopmentfrom
GH60-integer-reading
Closed

[Improve] attribute reading#61
samatstariongroup wants to merge 5 commits intodevelopmentfrom
GH60-integer-reading

Conversation

@samatstariongroup
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the ReqIFSharp code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

[Refactor] reading xml attributes, set properties to a default value when an overflow exception on XmlConvert is handled; fixes #60
[Update] all int properties to long to harmonize integer properties; as per ReqIF specification integers are mathematically unbounded integer. Practically long is a useful type
[Improve] logging when element not know -> include LineNumber and LinePosition

…when an overflow exception on XmlConvert is handled; fixes #60

[Update] all int properties to long to harmonize integer properties; as per ReqIF specification integers are mathematically unbounded integer. Practically long is a useful type

[Improve] logging when element not know -> include LineNumber  and LinePosition
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
74.5% Coverage on New Code (required ≥ 80%)
6.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@samatstariongroup samatstariongroup deleted the GH60-integer-reading branch November 12, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deserialization crashes when DATATYPE-DEFINITION-STRING/@MAX-LENGTH is UInt32.Max

2 participants

Comments