[autobackport: sssd-2-9] sdap: handle missing rootDSE gracefully#8735
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces changes to handle missing rootDSE gracefully in sdap_async_connection.c. However, the changes contain multiple unresolved git merge conflict markers (such as <<<<<<< HEAD, =======, and >>>>>>>), which will prevent compilation. These conflict markers must be resolved and cleaned up.
7a96d83 to
4d9dd2f
Compare
If `ldap_read_rootdse = never` then srv_opts is NULL which is unexpected. It can also happen on other path in the connection code, because sdap_cli_use_rootdse() is called only when the rootDSE is successfully fetch. This patch makes sure that srv_opts are always set. :fixes: SSSD no longer crashes if `ldap_read_rootdse = never` and `enumerate = true` Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Tomáš Halman <thalman@redhat.com> (cherry picked from commit 2cc7dfa)
|
The pull request was accepted by @alexey-tikhonov with the following PR CI status: 🟢 CodeQL (success) There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging. |
4d9dd2f to
efd8df8
Compare
This is an automatic backport of PR#8706 sdap: handle missing rootDSE gracefully to branch sssd-2-9, created by @pbrezina.
Caution
@pbrezina The patches did not apply cleanly. It is necessary to resolve conflicts before merging this pull request. Commits that introduced conflict are marked with
CONFLICT!.You can push changes to this pull request
Original commits
2cc7dfa - sdap: handle missing rootDSE gracefully
Backported commits
Conflicting Files Information (check for deleted and re-added files)
Original Pull Request Body
If
ldap_read_rootdse = neverthen srv_opts which is unexpected. It canalso happen on other path in the connection code, because
sdap_cli_use_rootdse() is called only when the rootDSE is successfully
fetch. This patch makes sure that srv_opts are always set.
:fixes: SSSD no longer crashes if
ldap_read_rootdse = neverandenumarete = true