[autobackport: sssd-2-13] tests: Clarify approx match filter#8730
Open
sssd-bot wants to merge 1 commit into
Open
[autobackport: sssd-2-13] tests: Clarify approx match filter#8730sssd-bot wants to merge 1 commit into
sssd-bot wants to merge 1 commit into
Conversation
Reviewed-by: Tomáš Halman <thalman@redhat.com> (cherry picked from commit 21674dd)
There was a problem hiding this comment.
Code Review
This pull request adds explanatory comments to the LDAP access control filter tests in src/tests/system/tests/test_access_control_ldap_filter.py. These comments document the provider-specific behavior of approximate match filters for AD, Samba, and 389ds, and provide context on how these filters affect authentication results for specific test users. I have no feedback to provide as there were no review comments.
thalman
approved these changes
May 25, 2026
Contributor
thalman
left a comment
There was a problem hiding this comment.
correctly backported, ACK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of PR#8714 tests: Clarify approx match filter to branch sssd-2-13, created by @justin-stephenson.
Please make sure this backport is correct.
Note
The commits were cherry-picked without conflicts.
You can push changes to this pull request
Original commits
21674dd - tests: Clarify approx match filter
Backported commits
Original Pull Request Body
Debugging this test for an unrelated issue (new failover) lead to several questions about 'approximate match' filter, adding some comments to make it more clear after some investigation.