Skip to content

[autobackport: sssd-2-9] tests: Clarify approx match filter#8729

Open
sssd-bot wants to merge 1 commit into
SSSD:sssd-2-9from
sssd-bot:SSSD-sssd-backport-pr8714-to-sssd-2-9
Open

[autobackport: sssd-2-9] tests: Clarify approx match filter#8729
sssd-bot wants to merge 1 commit into
SSSD:sssd-2-9from
sssd-bot:SSSD-sssd-backport-pr8714-to-sssd-2-9

Conversation

@sssd-bot
Copy link
Copy Markdown
Contributor

This is an automatic backport of PR#8714 tests: Clarify approx match filter to branch sssd-2-9, created by @justin-stephenson.

Please make sure this backport is correct.

Note

The commits were cherry-picked without conflicts.

You can push changes to this pull request

git remote add sssd-bot git@github.com:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr8714-to-sssd-2-9
git checkout SSSD-sssd-backport-pr8714-to-sssd-2-9
git push sssd-bot SSSD-sssd-backport-pr8714-to-sssd-2-9 --force

Original commits
21674dd - tests: Clarify approx match filter

Backported commits

  • 892d2e4 - tests: Clarify approx match filter

Original Pull Request Body

Debugging this test for an unrelated issue (new failover) lead to several questions about 'approximate match' filter, adding some comments to make it more clear after some investigation.

Reviewed-by: Tomáš Halman <thalman@redhat.com>
(cherry picked from commit 21674dd)
@sssd-bot sssd-bot requested a review from thalman May 25, 2026 13:08
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds explanatory comments to the LDAP access control filter tests to clarify provider-specific behaviors for approximate matching across AD, Samba, and 389ds. It also includes a note on how Samba handles unsupported filters during authentication checks. I have no feedback to provide as there were no review comments to assess.

Copy link
Copy Markdown
Contributor

@thalman thalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctly backported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants