[autobackport: sssd-2-10] ci: add TMT plan for passkey testing in PRCI#8726
[autobackport: sssd-2-10] ci: add TMT plan for passkey testing in PRCI#8726sssd-bot wants to merge 2 commits into
Conversation
Add comprehensive TMT plan for testing SSSD passkey functionality across IPA, LDAP, and Samba identity providers using containerized environments. Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com> Co-authored-by: Claude Sonnet 4 <noreply@anthropic.com> Reviewed-by: Jakub Vávra <jvavra@redhat.com> Reviewed-by: Justin Stephenson <jstephen@redhat.com> (cherry picked from commit d54cf52)
Enable automated passkey testing on pull requests after COPR builds complete. Tests run on fedora-all and centos-stream-10 targets using the TMT plan. Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com> Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com> Reviewed-by: Jakub Vávra <jvavra@redhat.com> Reviewed-by: Justin Stephenson <jstephen@redhat.com> (cherry picked from commit 210f50f)
|
Failed to load packit config file: For more info, please check out the documentation or contact the Packit team. You can also use our CLI command |
There was a problem hiding this comment.
Code Review
This pull request introduces a new TMT test plan for SSSD passkey functionality and updates the Packit configuration to include automated testing, downstream proposals, and Koji builds. However, the reviewer identified critical issues that must be addressed: the .packit.yaml file contains unresolved git conflict markers that render the configuration invalid, and the test plan's repository cloning logic incorrectly defaults to the master branch instead of the appropriate stable branch for this backport.
| git checkout "pr-$PACKIT_PR_ID" | ||
| else | ||
| echo "No PR context found, master branch fallback" | ||
| git clone https://github.com/SSSD/sssd.git /tmp/sssd |
There was a problem hiding this comment.
In this backport to the sssd-2-10 branch, the fallback logic for cloning the repository defaults to the master branch. This is incorrect for a stable branch backport as it will result in testing the master code instead of the sssd-2-10 code when no PR context is detected. The clone command should explicitly target the sssd-2-10 branch.
git clone --branch sssd-2-10 https://github.com/SSSD/sssd.git /tmp/sssd
There was a problem hiding this comment.
This is correct and I will implement it
This is an automatic backport of PR#8672 ci: add TMT plan for passkey testing in PRCI to branch sssd-2-10, created by @ikerexxe.
Caution
@ikerexxe The patches did not apply cleanly. It is necessary to resolve conflicts before merging this pull request. Commits that introduced conflict are marked with
CONFLICT!.You can push changes to this pull request
Original commits
d54cf52 - tests: add TMT plan for passkey testing
210f50f - ci: add TMT passkey tests to packit workflow
Backported commits
Conflicting Files Information (check for deleted and re-added files)
Original Pull Request Body
Summary
This PR introduces testing infrastructure for SSSD passkey functionality using TMT and testing farm. It is designed to automate verification across diverse environments and integrate directly into the existing Packit CI workflow.
Changes Made
Test Plan
The TMT plan follows an automated lifecycle for each PR:
Constraints & known limitations
fedora-all, containers inherit the distribution of the host VM (e.g., F44 VM hosts F44 containers). This approach links test stability to the target distribution’s stability. Rawhide environments may occasionally experience failures due to upstream shifts unrelated to SSSD.Observability & debugging
If a test fails, kKey data can be found at:
tmt-logand test artifacts directory:plans/passkey/data/artifacts/tests/Final notes