krb5: improve reporting failure on reading keytab#8530
krb5: improve reporting failure on reading keytab#8530257 wants to merge 1 commit intoSSSD:masterfrom
Conversation
There was a problem hiding this comment.
Code Review
The pull request introduces a valuable check for keytab file readability, which enhances error reporting and robustness. This is a good improvement for handling cases where the keytab file exists but cannot be accessed by the process. However, a typo was introduced in the debug message for this new check.
27cb9fe to
fa4a69d
Compare
|
Perhaps tests need update: But what is your use case? Typically 'krb5_child' has |
will have a look
in our case, our logs would show: actual problem was that the build pipeline (homegrown, based on obviously logs didn't help in our troubleshooting hence this patch. (although it pointed to the right direction) chown'ing that file to: a side note, I have two questions:
does that mean that the ownership already has to be set for the user? |
That's actually pretty typical ownership. Can you check output of I suspect file capabilities are lost in your image.
Thank you.
This also works, in this case SSSD binaries in your image don't need 'cap_dac_read_search'.
That's an interesting option, we didn't explore it yet.
...
No, it's not required. |
comes up empty! in fact i ended up chown'in build script (gentoo's portage) indeed passes
they're indeed lost, great call; thanks. i cooked up something for the distro, waiting for their feedback. |
also, s/has not entries/has no entries/ when keytab_file has actually no entries. Signed-off-by: Paymon MARANDI <paymon@encs.concordia.ca>
fa4a69d to
74a4f89
Compare
You might want to sync with @salahcoronya on this. |
also, s/has not entries/has no entries/ when keytab_file has actually
no entries.
Signed-off-by: Paymon MARANDI paymon@encs.concordia.ca