Refactor entities to be subclasses of generic ones#244
Open
jakub-vavra-cz wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors local user, group, and netgroup utilities to inherit from generic base roles, standardizing the API and introducing type aliases for sudo rule fields. It also extends the LocalUser class with password management and expiration methods. Feedback was provided to update docstrings in LocalSudoRule that contain outdated type references or lack parameter descriptions.
jakub-vavra-cz
changed the title
jakub-vavra-cz
force-pushed
the
generics
branch
6 times, most recently
from
ad35478 to
56422a5
Compare
Subclass entities from ad, ipa, ldap, samba from generic ones. Fix E741 violation in automount.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want all Users, Groups, SudoRules to have the same interface as generic ones.