Skip to content

Replaced the bundled sqlite sources with the ones retrieving the lib from the official website.#261

Open
KOLANICH wants to merge 1 commit into
SRombauts:masterfrom
KOLANICH-libs:sqlite_download
Open

Replaced the bundled sqlite sources with the ones retrieving the lib from the official website.#261
KOLANICH wants to merge 1 commit into
SRombauts:masterfrom
KOLANICH-libs:sqlite_download

Conversation

@KOLANICH

@KOLANICH KOLANICH commented Jan 14, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@SRombauts SRombauts self-assigned this Jan 14, 2020
@SRombauts

SRombauts commented Jan 30, 2020

Copy link
Copy Markdown
Owner

Hello @KOLANICH
I actually don't think it's a good idea to not have a copy of SQLite3 source code directly on the.
I also cannot request all users to move to such a recent CMake 3.14, it's not supported by popular CI systems

Perhaps could you make the Fetch feature optional?

Cheers!

@KOLANICH
KOLANICH force-pushed the sqlite_download branch 2 times, most recently from c8c050b to c5c7886 Compare February 11, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@SRombauts SRombauts

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KOLANICH @SRombauts