fix: make extend_sqlglot idempotent - #5936
Closed
sravankumarkunadi wants to merge 1 commit into
Closed
Conversation
Signed-off-by: sravankumarkunadi <sravankumarkunadi@users.noreply.github.com>
Contributor
Author
|
Closing as a duplicate of #5921, which has the same fix and is already approved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5908.
_overridesaved whatever was currently installed under_<name>, so callingextend_sqlglot()a second time saved the SQLMesh wrapper as "the original". After that_parse_typescalled itself and every CAST/type parse in the process raisedRecursionError, with sqlglot's real method gone. It doesn't need a deliberate double call:extend_sqlglot()is the first line ofsqlmesh/__init__.py, so if anything later in that import fails, the package is evicted while the patchedParserstays behind, and the nextimport sqlmeshtriggers it._overridenow returns early if the wrapper is already installed, andUNWRAPPED_INTERVAL_VALUESgets the same membership guardTRANSFORMSandWITH_SEPARATED_COMMENTSalready had (it was growing by two entries per call).Added
test_extend_sqlglot_is_idempotent, which fails on main with the recursion assertion and passes here.