Skip to content

Clinical course tab has been disabled for LTB of all countries#14088

Merged
KarnaiahPesula merged 2 commits into
developmentfrom
bugfix-14038-clinical-course-non-lux-hiding
Jun 30, 2026
Merged

Clinical course tab has been disabled for LTB of all countries#14088
KarnaiahPesula merged 2 commits into
developmentfrom
bugfix-14038-clinical-course-non-lux-hiding

Conversation

@KarnaiahPesula

@KarnaiahPesula KarnaiahPesula commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Fixes #

Summary by CodeRabbit

  • Bug Fixes
    • Updated case menu visibility so the Clinical Course section follows the latest disease- and region-specific rules.
    • Refined which diseases hide or disable Clinical Course, including updated handling for latent tuberculosis and influenza.

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 800c234f-b029-428f-8479-9ae4315fab02

📥 Commits

Reviewing files that changed from the base of the PR and between a61b5cc and 4237a7e.

📒 Files selected for processing (1)
  • sormas-ui/src/main/java/de/symeda/sormas/ui/caze/AbstractCaseView.java
🚧 Files skipped from review as they are similar to previous changes (1)
  • sormas-ui/src/main/java/de/symeda/sormas/ui/caze/AbstractCaseView.java

📝 Walkthrough

Walkthrough

AbstractCaseView splits Clinical Course exclusion rules into Luxembourg and non-Luxembourg disease sets, adds a local country flag, and updates the menu check so Clinical Course visibility follows the new disease/country split.

Clinical Course Tab Visibility

Layer / File(s) Summary
Disease sets and refreshMenu condition
sormas-ui/src/main/java/de/symeda/sormas/ui/caze/AbstractCaseView.java
CLINICAL_COURSE_DISABLED_DISEASES drops LATENT_TUBERCULOSIS; NON_LUX_CLINICAL_COURSE_DISABLED_DISEASES adds LATENT_TUBERCULOSIS and INFLUENZA. refreshMenu now derives isLuxembourg, computes isDiseaseDisabled, and gates ClinicalCourseView on that result.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

Suggested reviewers

  • roldy
  • raulbob

Poem

🐇 I hopped through the menu, by country and disease,
Lux and non-Lux now dance with greater ease.
LTB and Influenza took separate trails,
And Clinical Course hides where the rule set prevails.

🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (3 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title is misleading because LTB is only disabled for non-Luxembourg cases, not for all countries. Rewrite the title to reflect the actual rule change, e.g. mention the non-Luxembourg Clinical Course visibility logic.
Description check ⚠️ Warning The description is just the template placeholder and does not include the required issue number or any meaningful details. Fill in the issue reference after 'Fixes #' and add a brief summary of the change and its intent.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bugfix-14038-clinical-course-non-lux-hiding

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@sormas-ui/src/main/java/de/symeda/sormas/ui/caze/AbstractCaseView.java`:
- Around line 236-241: The clinical course availability condition in
AbstractCaseView is applying NON_LUX_CLINICAL_COURSE_DISABLED_DISEASES for every
country, which incorrectly hides the tab for Luxembourg cases too. Update the
visibility logic around the caze disease checks so the
NON_LUX_CLINICAL_COURSE_DISABLED_DISEASES branch is only enforced when the
country is not Luxembourg, while keeping the existing Luxembourg-specific
CLINICAL_COURSE_DISABLED_DISEASES handling intact. Use the AbstractCaseView
condition and the
FacadeProvider.getConfigFacade().isConfiguredCountry(CountryHelper.COUNTRY_CODE_LUXEMBOURG)
check to scope the disease list correctly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2500c296-4f73-4bb3-b04a-4fe749f0baaf

📥 Commits

Reviewing files that changed from the base of the PR and between 9a59c61 and a61b5cc.

📒 Files selected for processing (1)
  • sormas-ui/src/main/java/de/symeda/sormas/ui/caze/AbstractCaseView.java

Comment thread sormas-ui/src/main/java/de/symeda/sormas/ui/caze/AbstractCaseView.java Outdated
@KarnaiahPesula KarnaiahPesula requested review from raulbob and roldy June 30, 2026 06:34
@KarnaiahPesula KarnaiahPesula merged commit 37cb9d8 into development Jun 30, 2026
7 checks passed
@KarnaiahPesula KarnaiahPesula deleted the bugfix-14038-clinical-course-non-lux-hiding branch June 30, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tabulations for Latent Tuberculosis infection are not following the requirements

2 participants