#14045 - Add exclusion for specific diseases in immunization management#14073
#14045 - Add exclusion for specific diseases in immunization management#14073raulbob wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthrough
Immunization panel disease exclusion
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@sormas-ui/src/main/java/de/symeda/sormas/ui/events/EventParticipantDataView.java`:
- Around line 178-180: The immunization visibility guard was added in
EventParticipantDataView, but the reported issue is in the case UI, so update
the equivalent check in the case data view instead. Find the corresponding
immunization panel logic in the case screen (around the case DTO/view handling)
and apply the same UiUtil.permitted, disease-null, and
IMMUNIZATION_EXCLUDED_DISEASES guard there so Shigellosis cases hide the panel
as intended.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: d7a13c8d-fdff-426d-ace5-ec8223cef59e
📒 Files selected for processing (1)
sormas-ui/src/main/java/de/symeda/sormas/ui/events/EventParticipantDataView.java
| if (UiUtil.permitted(FeatureType.IMMUNIZATION_MANAGEMENT, UserRight.IMMUNIZATION_VIEW) | ||
| && event.getDisease() != null | ||
| && !IMMUNIZATION_EXCLUDED_DISEASES.contains(event.getDisease())) { |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
This change targets the wrong screen for issue #14045.
EventParticipantDataView only affects event participants (EventParticipantDto/EventDto), but the linked bug is about hiding immunization in the case view for Shigellosis. Unless the equivalent guard was also added to the case data view, the reported UI will still show the panel there.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@sormas-ui/src/main/java/de/symeda/sormas/ui/events/EventParticipantDataView.java`
around lines 178 - 180, The immunization visibility guard was added in
EventParticipantDataView, but the reported issue is in the case UI, so update
the equivalent check in the case data view instead. Find the corresponding
immunization panel logic in the case screen (around the case DTO/view handling)
and apply the same UiUtil.permitted, disease-null, and
IMMUNIZATION_EXCLUDED_DISEASES guard there so Shigellosis cases hide the panel
as intended.
Fixes #14045
Summary by CodeRabbit