Skip to content

Feat/minimessage tags - #399

Merged
twisti-dev merged 2 commits into
version/26.2from
feat/minimessage-tags
Jul 25, 2026
Merged

Feat/minimessage tags#399
twisti-dev merged 2 commits into
version/26.2from
feat/minimessage-tags

Conversation

@TheBjoRedCraft

Copy link
Copy Markdown
Contributor

No description provided.

- introduce SmallCapsTag to convert text to small caps using toSmallCaps function
- update miniMessage method to include new "small" tag for text formatting
- enhance smallCapsMap visibility by changing it to internal
- introduce SmallCapsTag to convert text to small caps using toSmallCaps function
- update miniMessage method to include new "small" tag for text formatting
- enhance smallCapsMap visibility by changing it to internal
@TheBjoRedCraft TheBjoRedCraft self-assigned this Jul 25, 2026
Copilot AI review requested due to automatic review settings July 25, 2026 09:59
@twisti-dev
twisti-dev enabled auto-merge July 25, 2026 10:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds new MiniMessage tags to the core Surf API MiniMessage holder to support additional themed formatting and a small-caps text transformation, plus bumps the project version.

Changes:

  • Register a new <note> color tag backed by Colors.NOTE.
  • Add a new <small> MiniMessage tag intended to render text in small caps via toSmallCaps().
  • Bump version from 3.33.4 to 3.33.5.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
surf-api-core/surf-api-core/src/main/kotlin/dev/slne/surf/api/core/minimessage/SurfMiniMessageHolder.kt Adds <note> color tag and a <small> modifying tag (small caps).
gradle.properties Bumps project version to 3.33.5.
Comments suppressed due to low confidence (2)

surf-api-core/surf-api-core/src/main/kotlin/dev/slne/surf/api/core/minimessage/SurfMiniMessageHolder.kt:106

  • SmallCapsTag.apply clears children for both TextComponent and non-TextComponent nodes. This will drop nested components produced by other tags (e.g., styles/gradients/hover/click content represented as children) and can change message structure unexpectedly. The modifier should generally preserve children and only adjust the current node’s text content when applicable.
            if (current is TextComponent) {
                return current.content(current.content().toSmallCaps())
                    .children(emptyList())
            }
            return current.children(emptyList())

surf-api-core/surf-api-core/src/main/kotlin/dev/slne/surf/api/core/minimessage/SurfMiniMessageHolder.kt:82

  • A new <small> tag is registered, but it isn’t documented in the KDoc “Available Custom Tags” section. Please add it (and what it does) so consumers can discover it.
            tagBuilder.tag("small") { _, _ -> SmallCapsTag() }
        }

@twisti-dev
twisti-dev added this pull request to the merge queue Jul 25, 2026
@mergify

mergify Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@mergify

mergify Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

queue

⚠️ Configuration not compatible with required_status_checks ruleset rule

Details

The ruleset rule parameter required_status_checks.strict_required_status_checks_policy is not compatible with draft PR checks. To keep this ruleset enabled, update your Mergify configuration to enable in-place checks: set merge_queue.max_parallel_checks: 1, set every queue rule batch_size: 1, and avoid two-step CI (make merge_conditions identical to queue_conditions). Otherwise, you can disable the Require branches to be up to date before merging option, or allow Mergify to bypass the ruleset or disable the entire ruleset.

@twisti-dev
twisti-dev removed this pull request from the merge queue due to a manual request Jul 25, 2026
@twisti-dev
twisti-dev merged commit b3d17bb into version/26.2 Jul 25, 2026
8 checks passed
@twisti-dev
twisti-dev deleted the feat/minimessage-tags branch July 25, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants