Skip to content

Feat/allow modificatio of title#247

Merged
ammodev merged 10 commits intoversion/1.21.11from
feat/allow-modificatio-of-title
Mar 14, 2026
Merged

Feat/allow modificatio of title#247
ammodev merged 10 commits intoversion/1.21.11from
feat/allow-modificatio-of-title

Conversation

@ammodev
Copy link
Contributor

@ammodev ammodev commented Mar 14, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 14, 2026 20:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the inventory view framework to allow dynamic title modification after initial rendering. It moves container initialization from onInit to onOpen, makes ViewContainer per-context via lazyState, and introduces a public modifyContainer DSL function. It also adds a ViewIcon system and includes minor fixes.

Changes:

  • Refactored container/title lifecycle: container state is now per-open-context, enabling title changes via a new header() DSL and public modifyContainer function
  • Added ViewIcon, ViewIconType, and ViewIconColor enums for standardized menu icon rendering
  • Minor improvements: early-return optimization in PacketLoreListener, method rename for clarity

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
AbstractSurfView.kt Container moved to lazyState, applyContainerDefaults moved to onOpen, modifyContainer now requires non-null Context
SurfViewDSLImpl.kt Removed view-scoped modifyContainer, exposed modifyContainer0 as internal
PaginatedSurfViewDSLImpl.kt Same refactor as SurfViewDSLImpl
SurfViewLifecycleDsl.kt Added public modifyContainer and header() DSL functions
ViewContainerDSL.kt Added header() function for setting container title
ViewContainerTitleComponent.kt Changed from internal to public
SurfViewBuilder.kt Removed ViewRef from builder context parameters
ViewIcon.kt New icon builder using Nexo item models
ViewIconType.kt Enum of available icon types
ViewIconColor.kt Enum of available icon colors
PacketLoreListener.kt Method rename + early-return when lore unchanged
gradle.properties Version bump to 2.63.2

@github-actions
Copy link
Contributor

⚠️ API/ABI changes detected!

This PR contains changes that modified the public API. To update the reference ABI dumps:

./gradlew updateLegacyAbi
git add **/api/**
git commit -m "Update ABI reference"
git push

After updating, the CI will pass. Make sure the changes are backward compatible.

@github-actions
Copy link
Contributor

⚠️ API/ABI changes detected!

This PR contains changes that modified the public API. To update the reference ABI dumps:

./gradlew updateLegacyAbi
git add **/api/**
git commit -m "Update ABI reference"
git push

After updating, the CI will pass. Make sure the changes are backward compatible.

@github-actions
Copy link
Contributor

⚠️ API/ABI changes detected!

This PR contains changes that modified the public API. To update the reference ABI dumps:

./gradlew updateLegacyAbi
git add **/api/**
git commit -m "Update ABI reference"
git push

After updating, the CI will pass. Make sure the changes are backward compatible.

ammodev and others added 4 commits March 14, 2026 23:55
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@ammodev ammodev merged commit 8346806 into version/1.21.11 Mar 14, 2026
4 checks passed
@ammodev ammodev deleted the feat/allow-modificatio-of-title branch March 14, 2026 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants