Prevent abnormal exit when connection failed#611
Open
alrod999 wants to merge 1 commit intoSIPp:masterfrom
Open
Prevent abnormal exit when connection failed#611alrod999 wants to merge 1 commit intoSIPp:masterfrom
alrod999 wants to merge 1 commit intoSIPp:masterfrom
Conversation
Currently, sipp exits abnormally if a TCP/TLS connection to the UAS is refused. This can also occur in multi-socket mode (tn/ln), where some users might prefer to ignore the error and keep running. I propose linking this behavior to the -reconnect_close option (the default behavior remains unchanged).
orgads
force-pushed
the
exit_on_connection_reject_fix
branch
from
2f6a3b6 to
dad3eb9
Compare
|
That looks great! |
Contributor
|
@neutrino38 did you test it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now the sipp exits abnormally when a connection (TCP/TLS) to UAS is refused. It might happen for "multi-socket" mode (tn/ln), and somebody may want to ignore the error and continue. I propose to bind it to the "-reconnect_close" option (default behavior won't change)