Gaia epoch ingest v2#686
Open
yzjanee wants to merge 5 commits intoSIMPLE-AstroDB:mainfrom
Open
Conversation
Without the changing of the other json files for the adopted fix. However, save_json still fixes it to a boolean for all these modified jsons under GaiaDR3. Changed to the newer build_db_from_json for the ingest script along with adding the tests.
remove zhang files that were accidentally added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to relevant issue: Closes #667
Complete Gaia Ingest v2, only with 1265 JSON files, with modified test scripts. With the 0/1 to true/false boolean change in the JSON files for the adopted field, it automatically updates for save_json. The other files are still untouched.