Add database toml#682
Merged
kelle merged 9 commits intoSIMPLE-AstroDB:mainfrom Apr 14, 2026
Merged
Conversation
Member
Author
|
did not remove |
Collaborator
|
yes, modify conftest to use the new method! |
kelle
reviewed
Apr 14, 2026
Co-authored-by: Kelle Cruz <kellecruz@gmail.com>
* initial commit ingest converted spectra * update original spectrum url + json files + pytest * update comment in ingesting script * Update data/reference/Instruments.json Co-authored-by: Kelle Cruz <kellecruz@gmail.com> * Update data/source/2mass_j06164006-6407194.json Co-authored-by: Kelle Cruz <kellecruz@gmail.com> * Update scripts/ingests/bones_archive/ingest_BONES_spectra.py Co-authored-by: Kelle Cruz <kellecruz@gmail.com> * update version to 5.3.2026.02 * fix schedule_checks.py --------- Co-authored-by: Kelle Cruz <kellecruz@gmail.com>
kelle
reviewed
Apr 14, 2026
kelle
approved these changes
Apr 14, 2026
Collaborator
kelle
left a comment
kelle
left a comment
There was a problem hiding this comment.
Assuming test pass, this looks good to me. Good job!
dr-rodriguez
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description: improve database settings in SIMPLE by adding
database.tomlfor new astrodb_utils functionLink to relevant issue: Closes #672