feat(cli): allow building packages for unknown distros - #25
Open
mikonse wants to merge 1 commit into
Open
Conversation
E.g. allows packaging for unknown debian / ubuntu derivates or other random distros like yocto which just happen to use apt / dpkg.
mikonse
force-pushed
the
milo/allow-non-debian-ubuntu-distros
branch
from
August 11, 2026 18:40
48c0ea5 to
f58a7af
Compare
TheJJ
requested changes
Aug 11, 2026
TheJJ
left a comment
TheJJ
left a comment
Member
There was a problem hiding this comment.
this complicates the distro handling quite a lot, i think we can design it better by using a custom distro enum value.
| use std::sync::LazyLock; | ||
|
|
||
| #[derive(Clone, Debug, Serialize, Deserialize, Eq, PartialEq, Hash)] | ||
| pub enum Distro { |
Member
There was a problem hiding this comment.
instead of getting rid of this, why not have a third "custom" entry?
then we can get rid of all the is_ functions and can still support any custom approach incl other package managers someday.
| } | ||
| } | ||
|
|
||
| fn check_bare_os_release_for_builtin( |
Member
There was a problem hiding this comment.
hm but what if we have dpkg/apt installed on gentoo? i think we can leave out this check, we should rather test if apt/dpkg/whatever the distro's pkg manager is, is available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E.g. allows packaging for unknown debian / ubuntu derivates or other random distros like yocto
which just happen to use apt / dpkg.