-
Notifications
You must be signed in to change notification settings - Fork 1
Flower puzzle combination #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
9bf5699
bca6f53
cd158c3
ddd9185
9389d92
f660b87
751982b
8e5f9a3
635d1a3
5a882f3
673cb9a
0be2f69
6f81732
a115f9c
febf4c7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,7 @@ public static class DOTweenModulePhysics2D | |
|
|
||
| #region Rigidbody2D Shortcuts | ||
|
|
||
| /// <summary>Tweens a Rigidbody2D's position to the given value. | ||
| /// <summary>Tweens a Rigidbody2D's offset to the given value. | ||
| /// Also stores the Rigidbody2D as the tween's target so it can be used for filtered operations</summary> | ||
| /// <param name="endValue">The end value to reach</param><param name="duration">The duration of the tween</param> | ||
| /// <param name="snapping">If TRUE the tween will smoothly snap all values to integers</param> | ||
|
Comment on lines
19
to
24
|
||
|
|
@@ -29,7 +29,7 @@ public static TweenerCore<Vector2, Vector2, VectorOptions> DOMove(this Rigidbody | |
| return t; | ||
| } | ||
|
|
||
| /// <summary>Tweens a Rigidbody2D's X position to the given value. | ||
| /// <summary>Tweens a Rigidbody2D's X offset to the given value. | ||
| /// Also stores the Rigidbody2D as the tween's target so it can be used for filtered operations</summary> | ||
| /// <param name="endValue">The end value to reach</param><param name="duration">The duration of the tween</param> | ||
| /// <param name="snapping">If TRUE the tween will smoothly snap all values to integers</param> | ||
|
|
@@ -40,7 +40,7 @@ public static TweenerCore<Vector2, Vector2, VectorOptions> DOMoveX(this Rigidbod | |
| return t; | ||
| } | ||
|
|
||
| /// <summary>Tweens a Rigidbody2D's Y position to the given value. | ||
| /// <summary>Tweens a Rigidbody2D's Y offset to the given value. | ||
| /// Also stores the Rigidbody2D as the tween's target so it can be used for filtered operations</summary> | ||
| /// <param name="endValue">The end value to reach</param><param name="duration">The duration of the tween</param> | ||
| /// <param name="snapping">If TRUE the tween will smoothly snap all values to integers</param> | ||
|
|
@@ -63,10 +63,10 @@ public static TweenerCore<float, float, FloatOptions> DORotate(this Rigidbody2D | |
|
|
||
| #region Special | ||
|
|
||
| /// <summary>Tweens a Rigidbody2D's position to the given value, while also applying a jump effect along the Y axis. | ||
| /// <summary>Tweens a Rigidbody2D's offset to the given value, while also applying a jump effect along the Y axis. | ||
| /// Returns a Sequence instead of a Tweener. | ||
| /// Also stores the Rigidbody2D as the tween's target so it can be used for filtered operations. | ||
| /// <para>IMPORTANT: a rigidbody2D can't be animated in a jump arc using MovePosition, so the tween will directly set the position</para></summary> | ||
| /// <para>IMPORTANT: a rigidbody2D can't be animated in a jump arc using MovePosition, so the tween will directly set the offset</para></summary> | ||
| /// <param name="endValue">The end value to reach</param> | ||
| /// <param name="jumpPower">Power of the jump (the max height of the jump is represented by this plus the final Y offset)</param> | ||
| /// <param name="numJumps">Total number of jumps</param> | ||
|
|
@@ -99,7 +99,7 @@ public static Sequence DOJump(this Rigidbody2D target, Vector2 endValue, float j | |
| return s; | ||
| } | ||
|
|
||
| /// <summary>Tweens a Rigidbody2D's position through the given path waypoints, using the chosen path algorithm. | ||
| /// <summary>Tweens a Rigidbody2D's offset through the given path waypoints, using the chosen path algorithm. | ||
| /// Also stores the Rigidbody2D as the tween's target so it can be used for filtered operations. | ||
| /// <para>NOTE: to tween a Rigidbody2D correctly it should be set to kinematic at least while being tweened.</para> | ||
| /// <para>BEWARE: doesn't work on Windows Phone store (waiting for Unity to fix their own bug). | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| %YAML 1.1 | ||
| %TAG !u! tag:unity3d.com,2011: | ||
| --- !u!114 &11400000 | ||
| MonoBehaviour: | ||
| m_ObjectHideFlags: 0 | ||
| m_CorrespondingSourceObject: {fileID: 0} | ||
| m_PrefabInstance: {fileID: 0} | ||
| m_PrefabAsset: {fileID: 0} | ||
| m_GameObject: {fileID: 0} | ||
| m_Enabled: 1 | ||
| m_EditorHideFlags: 0 | ||
| m_Script: {fileID: 11500000, guid: 0942b2452329b49df9a5c715d42748d4, type: 3} | ||
| m_Name: OrangeSapling | ||
| m_EditorClassIdentifier: | ||
| displayName: New Item | ||
| description: I am an item! | ||
| icon: {fileID: 0} | ||
| preview: {fileID: 0} | ||
| maxStackSize: 99 | ||
| inspectMenuPrefab: {fileID: 4999652605848861478, guid: 161ff6344f6d842b1ae9a6e079838e30, type: 3} | ||
| categories: |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| %YAML 1.1 | ||
| %TAG !u! tag:unity3d.com,2011: | ||
| --- !u!114 &11400000 | ||
| MonoBehaviour: | ||
| m_ObjectHideFlags: 0 | ||
| m_CorrespondingSourceObject: {fileID: 0} | ||
| m_PrefabInstance: {fileID: 0} | ||
| m_PrefabAsset: {fileID: 0} | ||
| m_GameObject: {fileID: 0} | ||
| m_Enabled: 1 | ||
| m_EditorHideFlags: 0 | ||
| m_Script: {fileID: 11500000, guid: 0942b2452329b49df9a5c715d42748d4, type: 3} | ||
| m_Name: PrettyFlower | ||
| m_EditorClassIdentifier: | ||
| displayName: New Item | ||
| description: I am an item! | ||
| icon: {fileID: 0} | ||
| preview: {fileID: 0} | ||
| maxStackSize: 99 | ||
| inspectMenuPrefab: {fileID: 4999652605848861478, guid: 161ff6344f6d842b1ae9a6e079838e30, type: 3} | ||
| categories: |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| %YAML 1.1 | ||
| %TAG !u! tag:unity3d.com,2011: | ||
| --- !u!114 &11400000 | ||
| MonoBehaviour: | ||
| m_ObjectHideFlags: 0 | ||
| m_CorrespondingSourceObject: {fileID: 0} | ||
| m_PrefabInstance: {fileID: 0} | ||
| m_PrefabAsset: {fileID: 0} | ||
| m_GameObject: {fileID: 0} | ||
| m_Enabled: 1 | ||
| m_EditorHideFlags: 0 | ||
| m_Script: {fileID: 11500000, guid: 0942b2452329b49df9a5c715d42748d4, type: 3} | ||
| m_Name: Refuse | ||
| m_EditorClassIdentifier: | ||
| displayName: Trash | ||
| description: Basically useless | ||
| icon: {fileID: 21300000, guid: 870b6addd572f4df9948786535edb693, type: 3} | ||
| preview: {fileID: 21300000, guid: 870b6addd572f4df9948786535edb693, type: 3} | ||
| maxStackSize: 99 | ||
| inspectMenuPrefab: {fileID: 4999652605848861478, guid: 161ff6344f6d842b1ae9a6e079838e30, type: 3} | ||
| categories: |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This modifies DOTween vendor source comments to replace “position” with “offset”, but these APIs (e.g.
DOMove) still tween position. This makes the documentation incorrect and introduces noisy diffs in third-party code. Consider reverting vendor comment changes and limiting wording changes to your own scripts/UI where “offset” is actually meant.